Date: Wed, 12 Sep 2001 10:02:47 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: current@FreeBSD.org, Julian Elischer <julian@elischer.org> Subject: Re: HEADSUP!!!! KSE Milestone-2 COMMITTED Message-ID: <XFMail.010912100247.jhb@FreeBSD.org> In-Reply-To: <20010912124407.E73589@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-Sep-01 Ruslan Ermilov wrote:
> Hello Julian!
>
> Could you please post the list of all changed and new kernel
> API functions so that -doc guys can keep up with this?
>
> Like suser_td(9), etc.
suser_td() is going away. p_ucred in the KSE kernel is still per-process, and
we need to hold the proc lock while we call suser() as a result (and we have to
hold it for the result of the test, so pushing the lock down into suser_td() is
not feasible). Thus, code that does this:
error = suser_td(td);
if (error)
return (error);
is going to become this:
struct proc *p = td->td_proc;
PROC_LOCK(p);
error = suser(p);
if (error) {
PROC_UNLOCK(p);
return;
}
.... /* do stuff */
PROC_UNLOCK(p);
I originally asked that the suser_td() changes not be made so that the locking
code doesn't have to go back all of them out again thus increasing the overall
diff size.
--
John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010912100247.jhb>