Date: Tue, 30 Jul 1996 00:46:45 -0700 From: "Jordan K. Hubbard" <jkh@time.cdrom.com> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org Subject: Re: cvs commit: src/etc rc Message-ID: <11797.838712805@time.cdrom.com> In-Reply-To: Your message of "Tue, 30 Jul 1996 17:20:46 %2B1000." <199607300720.RAA07220@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Well, I certainly wasn't setting out to right all of sysinstall's
wrongs, just that one submission. ;) If anyone's interested in going
on a cleanup rampage in there, please, be my most welcome guest! :-)
Jordan
> > Modified: etc rc
> > Log:
> > Edit this for consistency's sake (though it's syntactically identical).
> > Noticed-By: "William A. Gill" <bill@duchess.wagill.com>
> >
> > Revision Changes Path
> > 1.96 +2 -2 src/etc/rc
>
> There are many more inconsistencies in sysconfig. NO is sometimes quoted
> and sometimes not. Mostly not. Quoting it mainly wastes space.
>
> Also, in rc, some (poor) comments say that the test is $foo != NO, but
> the test is actually "X${foo}" != X"NO". The braces mainly waste space.
> Other (poor) comments say that the test is $foo == NO for the reverse
> condition, but == isn't an operator for `test'.
>
> Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11797.838712805>