Date: Tue, 9 Dec 2014 14:28:46 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: Brad Davis <brd@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r275657 - head/usr.sbin/pw/tests Message-ID: <CAGHfRMDm1sn7JoMNe4w6hi7Cs5xhkypCDAqVvd=S%2B4cqvMH9Kw@mail.gmail.com> In-Reply-To: <201412092211.sB9MBvHO033086@svn.freebsd.org> References: <201412092211.sB9MBvHO033086@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Brad! On Tue, Dec 9, 2014 at 2:11 PM, Brad Davis <brd@freebsd.org> wrote: > Author: brd (doc committer) > Date: Tue Dec 9 22:11:56 2014 > New Revision: 275657 > URL: https://svnweb.freebsd.org/changeset/base/275657 > > Log: > Add some tests for user modification. [1] > Fix a missing test in the Makefile from my previous commit. > > PR: 195834 [1] > Submitted by: Robert O'Neil <oneil.rs@gmail.com> > Approved by: will > > Added: > head/usr.sbin/pw/tests/pw_usermod.sh (contents, props changed) > Modified: > head/usr.sbin/pw/tests/Makefile > > Modified: head/usr.sbin/pw/tests/Makefile > ============================================================================== > --- head/usr.sbin/pw/tests/Makefile Tue Dec 9 21:43:03 2014 (r275656) > +++ head/usr.sbin/pw/tests/Makefile Tue Dec 9 22:11:56 2014 (r275657) > @@ -5,11 +5,13 @@ TESTSRC= ${.CURDIR}/../../../contrib/net > > TESTSDIR= ${TESTSBASE}/usr.sbin/pw > > -ATF_TESTS_SH= pw_etcdir pw_lock pw_groupmod pw_useradd pw_userdel > +ATF_TESTS_SH= pw_etcdir pw_lock pw_groupdel pw_groupmod pw_useradd pw_userdel pw_usermod Please put this one item per-line so it's easier to backport and doesn't exceed 80 columns. > +TEST_METADATA.pw_groupdel+= required_user="root" > TEST_METADATA.pw_groupmod+= required_user="root" > TEST_METADATA.pw_useradd+= required_user="root" > TEST_METADATA.pw_userdel+= required_user="root" > +TEST_METADATA.pw_usermod+= required_user="root" This should probably just be a for-loop, e.g. .for tp in ${ATF_TESTS_SH} TEST_METADATA.${tp}+= required_user="root" .endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMDm1sn7JoMNe4w6hi7Cs5xhkypCDAqVvd=S%2B4cqvMH9Kw>