Date: Thu, 1 Apr 2010 13:07:24 -0700 From: Xin LI <delphij@gmail.com> To: Tom Uffner <tom@uffner.com> Cc: freebsd-current@freebsd.org Subject: Re: HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz lib/libz/contrib lib/libz/doc sys/sys] Message-ID: <y2ia78074951004011307qdaf250fcicf46a25a7301248d@mail.gmail.com> In-Reply-To: <4BB4FB35.2040703@uffner.com> References: <4BA7E0B8.3080406@delphij.net> <4BAE2B4F.6060005@protected-networks.net> <4BB3FD5D.9070600@uffner.com> <r2oa78074951003312051kca872e0el511273674bd9e4b@mail.gmail.com> <4BB4FB35.2040703@uffner.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 1, 2010 at 12:59 PM, Tom Uffner <tom@uffner.com> wrote: > Xin LI wrote: >> >> On Wed, Mar 31, 2010 at 6:56 PM, Tom Uffner<tom@uffner.com> =C2=A0wrote: >>> >>> Michael Butler wrote: >>> >>>> This breaks most (if not all) of the QT4-dependent ports for the lack = of >>>> a definition of "off64_t". >>> >>> it also breaks multimedia/mplayer, graphics/ImageMagick, and >>> print/ghostscript8 & everything that depends on it. >> >> Just because they used to compile DOES NOT mean they were right. =C2=A0I= t's >> NOT right to define _LARGEFILE64_SOURCE on FreeBSD, see: >> >> http://www.delorie.com/gnu/docs/glibc/libc_13.html > > i realize this. i was just adding to the list of ports that no longer > build after this change. ghostscript is kind of important for print > support. > > i doubt this is "right" either, but it is a quick & dirty way to > make mplayer compile again: > > --- configure.orig =C2=A0 =C2=A0 =C2=A02010-04-01 15:49:37.000000000 -040= 0 > +++ configure =C2=A0 2010-04-01 15:50:50.000000000 -0400 > @@ -5337,7 +5337,7 @@ > =C2=A0#include <dvdread/nav_read.h> > =C2=A0int main(void) { return 0; } > =C2=A0EOF > - =C2=A0 =C2=A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 > -D_LARGEFILE64_SOURCE \ > + =C2=A0 =C2=A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 \ > =C2=A0 =C2=A0 =C2=A0 -ldvdread $_ld_dl && _dvdread=3Dyes && _res_comment= =3D"external" > =C2=A0 fi > =C2=A0fi > @@ -7412,8 +7412,6 @@ > =C2=A0if test "$_largefiles" =3D yes || freebsd ; then > =C2=A0 CFLAGS=3D"$CFLAGS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64" > =C2=A0 if test "$_dvdread" =3D yes || test "$_libdvdcss_internal" =3D yes= ; then > - =C2=A0 =C2=A0# dvdread support requires this (for off64_t) > - =C2=A0 =C2=A0CFLAGS=3D"$CFLAGS -D_LARGEFILE64_SOURCE" > =C2=A0 =C2=A0 cygwin && CFLAGS=3D"$CFLAGS -DSYS_CYGWIN" > =C2=A0 fi > =C2=A0fi I think the latest (1.2.4.1) zlib has a bug that prevents using -D_LARGEFILE64_SOURCE at all, and expects -D_LARGEFILE64_SOURCE=3D1. I'll submit a patch to upstream :( Cheers, --=20 Xin LI <delphij@delphij.net> http://www.delphij.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y2ia78074951004011307qdaf250fcicf46a25a7301248d>