Date: Mon, 19 Aug 2013 20:45:22 +0200 From: Mario Oshogbo <oshogbo@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r254440 - head/usr.sbin/rwhod Message-ID: <521267C2.60001@FreeBSD.org> In-Reply-To: <201308170712.r7H7CrYi089636@svn.freebsd.org> References: <201308170712.r7H7CrYi089636@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Thank you for your commit and sorry for not repair this problem earlier.
> @@ -274,6 +274,15 @@ main(int argc, char *argv[])
> exit(1);
> if (!quiet_mode) {
> pid_child_receiver = pdfork(&fdp, 0);
> + if (pid_child_receiver == -1) {
> + if (errno != ENOSYS) {
> + syslog(LOG_ERR, "pdfork: %m");
> + exit(1);
> + } else {
> + pid_child_receiver = fork();
> + fdp = -1;
> + }
> + }
We can't do it this way. pdfork() is used there to prevent killing only
one process. If we use fork() and we kill parent process the second
process (child process) will become a zombie process. I suggest to
revert this change. The changes that Pawel commit (r254486 (thx
jilles!!!) and r254480) should resolve all problems.
Cheers,
oshogbo
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJSEmfKAAoJECRkYejLhN/j110P+wSFH6758IUP7EpStQ3vNAtR
k1+bjZo/nLnhP3uu2UlBrYhurNmIh3ch4lkdnn/ah5PlzUUBugdHKuTJP68cWND4
2Ks1H5gK0zucnJDdnvFeBwOdbGFXEdzv2otO7vm6bULe1AgtaHFNGCkmhlMZLaY+
4K9CmzePOAmwuN2BKkv810F013lcX7jh8910hZrwSlgFkICDwdzX2BVou4mmAhIb
3oHgvNG9bE87377D2UYjn4teN+/Saa0BLqtrujuVF8rF4XHpT469cLTVCHs/7CPz
cD5CtWyEHQvGgBvssEB//dZ7+j7Q11u+UJ118ZoCruH3mpTfbHyE6L75evTQzoX2
/reDeIydpWn6xtZz2bd0XOWjDA8PQej6DdmLt1wwiOfrRpiDabSduXE++flcuPwr
5T6eJGu68IedxE+O4mFU131FT1Gq+olT8X0I+C+K9Hc63gVPXZE0vfaR5epAGWlx
lvMLTKZ6bJn7p5uy5yetgulcxxrY73u0ha20OVgIZ9jOiW55e6f9CgfAALG0aqiZ
0G7cSwNwkpzQ63tdO705vHfjjxI72Pgr53UyXaou5M9DTBOhTNHzBA4ffkIZhbVy
j/3dAsvRCnbFbb+8+4rnxP+YEiHdzsAFPqnNaLePziE8MZBWYCVPtFyRdOU2LzBt
gBk+3kglVFTwBLJFk5U+
=R5sD
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?521267C2.60001>