Date: Mon, 7 Jul 2025 23:18:18 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 034b3515ea27 - main - cam/xpt: improve comment on xpt_path_inq Message-ID: <202507072318.567NIIML045615@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=034b3515ea274b144eb514e83b2e10be0e5b71a9 commit 034b3515ea274b144eb514e83b2e10be0e5b71a9 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2025-07-07 20:04:33 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-07-07 23:17:00 +0000 cam/xpt: improve comment on xpt_path_inq Fix a comment about bzero maybe unnecessary. It can sometimes be redunant, but a common usage pattern puts the ccb_pathinq structure on the stack since it's small and for that scenario, it's required. It's reundant for the few places the ccb is allocated, and in those cases it does no harm. Sponsored by: Netflix Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D51166 --- sys/cam/cam_xpt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/cam/cam_xpt.h b/sys/cam/cam_xpt.h index 06ef52580120..fa4bee97b8f7 100644 --- a/sys/cam/cam_xpt.h +++ b/sys/cam/cam_xpt.h @@ -145,8 +145,8 @@ uint32_t xpt_poll_setup(union ccb *start_ccb); void xpt_sim_poll(struct cam_sim *sim); /* - * Perform a path inquiry at the request priority. The bzero may be - * unnecessary. + * Perform a path inquiry at the request priority. bzero may be redundant for + * allocated CCBs, but for the on-stack CCBs it's required. */ static inline void xpt_path_inq(struct ccb_pathinq *cpi, struct cam_path *path)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507072318.567NIIML045615>