Date: Fri, 28 May 2021 19:31:57 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Joseph Mingrone <jrm@freebsd.org> Cc: Allan Jude <allanjude@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f45d21ec05cc - main - www/varnish-libvmod-maxminddb: Update to version 1.0.2 Message-ID: <YLFFLeoM2ye3UC7x@FreeBSD.org> In-Reply-To: <86tummpstc.fsf@phe.ftfl.ca> References: <202105281835.14SIZNdV086090@gitrepo.freebsd.org> <YLE9IwizzCAkoO3P@FreeBSD.org> <86tummpstc.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 28, 2021 at 04:22:07PM -0300, Joseph Mingrone wrote: > On Fri, 2021-05-28 at 18:57, Alexey Dokuchaev wrote: > ... > > Can you actually ask for review from someone who has a clue next time? > > > This is by far not the first time I see bogus commit from src guy while > > it has seemingly proper "approved by" attribution in place. I honestly > > don't understand how does it end up like this. > > I think you are blowing things out of proportion. Please look through my > commit history and I think you will generally see careful testing and > very little breakage. Right, that's correct; I admit I deliberately didn't look at who had approved this commit so my reaction won't be biased. Your own commits are fine and you do take proper care Joe. > Alexey, your reaction is hurtful. The next time you make a mistake, I > will make every effort to be more respectful than you. I apologize; I should not have jumped onto this so promptly. I've also violated one of the phk@'s rules of email conduct, neglecting to read entire inbox first. :( ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YLFFLeoM2ye3UC7x>