Date: Fri, 14 Mar 2014 10:32:53 +0100 From: Hans Petter Selasky <hps@bitfrost.no> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r262972 - head/sys/dev/usb/input Message-ID: <5322CCC5.7020608@bitfrost.no> In-Reply-To: <D62898EB-F179-416B-A481-68604873477C@FreeBSD.org> References: <201403100852.s2A8qUdC045704@svn.freebsd.org> <D62898EB-F179-416B-A481-68604873477C@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/14/14 03:15, Rui Paulo wrote: > On 10 Mar 2014, at 01:52, Hans Petter Selasky <hselasky@freebsd.org> wrote: > >> Author: hselasky >> Date: Mon Mar 10 08:52:30 2014 >> New Revision: 262972 >> URL: http://svnweb.freebsd.org/changeset/base/262972 >> >> Log: >> Ignore USB keyboard driver calls from critical sections. >> >> Reported by: Oliver Pinter <oliver.pntr@gmail.com> >> MFC after: 1 week >> >> Modified: >> head/sys/dev/usb/input/ukbd.c >> >> Modified: head/sys/dev/usb/input/ukbd.c >> ============================================================================== >> --- head/sys/dev/usb/input/ukbd.c Mon Mar 10 06:41:48 2014 (r262971) >> +++ head/sys/dev/usb/input/ukbd.c Mon Mar 10 08:52:30 2014 (r262972) >> @@ -1909,6 +1909,12 @@ ukbd_ioctl(keyboard_t *kbd, u_long cmd, >> int result; >> >> /* >> + * XXX Check of someone is calling us from a critical section: >> + */ >> + if (curthread->td_critnest != 0) >> + return (EDEADLK); > > Shouldn't this panic? > > -- > Rui Paulo > Hi, This happens on shutdown, in some special case. Not sure if panic at shutdown is appropriate? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5322CCC5.7020608>