Date: Mon, 10 Nov 1997 21:16:28 +0000 From: Brian Somers <brian@awfulhak.org> To: Eivind Eklund <perhaps@yes.no> Cc: Brian Somers <brian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c modem.c modem.h os.c route.c Message-ID: <199711102116.VAA07993@awfulhak.demon.co.uk> In-Reply-To: Your message of "Mon, 10 Nov 1997 13:28:43 %2B0100." <199711101228.NAA17807@bitbox.follo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> >
> > brian 1997/11/07 16:28:12 PST
> >
> > Modified files:
> > usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c
> > modem.c modem.h os.c route.c
> > Log:
> > Don't pass global vars as args.
>
> I don't think patching away that is a good idea. The goal should be
> to make the global variables static/local; this kind of passing should
> be introduced more places, not removed. Then you can make the global
> variable static/dynamic somewhere later.
I agree. I hate globals with a vengence :-| They'll all go at some
point. The above was a quick improvement so that there's now no
obscure name-space confusion.
Once I get the security stuff finished, I'm going to try implementing
a multilink capability. I'm trying to get comfortable with
everything in the code first so that I don't go breaking
functionality that I don't already know about :-)
> IMNSHO,
> Eivind.
--
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org>
<http://www.Awfulhak.org>;
Don't _EVER_ lose your sense of humour....
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199711102116.VAA07993>