Date: Mon, 12 Feb 2018 09:07:32 -0700 From: Warner Losh <imp@bsdimp.com> To: Joerg Sonnenberger <joerg@bec.de> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include Message-ID: <CANCZdfoEAd8s8KvU_CazQKT%2Bc-ZjHdgTaH6b-3bLR2m51hi8rg@mail.gmail.com> In-Reply-To: <20180212155749.GA27160@britannica.bec.de> References: <201802121448.w1CEmEUX082701@repo.freebsd.org> <20180212155749.GA27160@britannica.bec.de>
index | next in thread | previous in thread | raw e-mail
On Mon, Feb 12, 2018 at 8:57 AM, Joerg Sonnenberger <joerg@bec.de> wrote: > On Mon, Feb 12, 2018 at 02:48:14PM +0000, Warner Losh wrote: > > Author: imp > > Date: Mon Feb 12 14:48:14 2018 > > New Revision: 329164 > > URL: https://svnweb.freebsd.org/changeset/base/329164 > > > > Log: > > We don't support gcc < 4.2.1, so varargs.h now is just #error > > always. Unifdef for versions prior to 4.2.1 and remove now-unused > > header files. > > In my experience it is better to really drop it. Keeping the header with > an #error is just creating *more* pain than having no header at all. > My change didn't change anything here. It already was a #error. I just changed it from #if <always true> #error #endif to #error. I'll leave it to the compliance folks to jump in and remove it. It's a posix header, it seems. But nobody is using it and it can't be causing widespread problems today or it would be on people's radar... It's not. Warnerhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoEAd8s8KvU_CazQKT%2Bc-ZjHdgTaH6b-3bLR2m51hi8rg>