Date: Mon, 15 Jan 2001 22:04:52 +0100 (CET) From: Soren Schmidt <sos@freebsd.dk> To: jhb@FreeBSD.org (John Baldwin) Cc: sos@FreeBSD.org (SXren Schmidt), cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c Message-ID: <200101152104.WAA65679@freebsd.dk> In-Reply-To: <XFMail.010115112824.jhb@FreeBSD.org> from John Baldwin at "Jan 15, 2001 11:28:24 am"
next in thread | previous in thread | raw e-mail | index | archive | help
It seems John Baldwin wrote: > > On 14-Jan-01 SXren Schmidt wrote: > > sos 2001/01/14 11:36:20 PST > > > > Modified files: > > sys/dev/ata ata-all.c > > Log: > > Use prober atomic operations when test&set'ing ->active. > > > > This turns some of my lockups under SMP into spontanious reboots... > > Erm, all of this should be running under Giant, so you shouldn't be contending > on this. You should probably protect this with a mutex that locks the softc > rather than using atomic operations, btw. If thats correct the change should have no effect right ? -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101152104.WAA65679>