Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Jul 2013 14:47:21 +0200
From:      Zbyszek Bodek <zbb@semihalf.com>
To:        Olivier Houchard <cognet@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r253762 - head/sys/arm/include
Message-ID:  <51F66459.7000500@semihalf.com>
In-Reply-To: <201307290807.r6T87Ztx098940@svn.freebsd.org>
References:  <201307290807.r6T87Ztx098940@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 29.07.2013 10:07, Olivier Houchard wrote:
> Author: cognet
> Date: Mon Jul 29 08:07:35 2013
> New Revision: 253762
> URL: http://svnweb.freebsd.org/changeset/base/253762
> 
> Log:
>   Define KDB_STOPPEDPCB, so that we can access the backtraces of threads running
>   on other cores.
> 
> Modified:
>   head/sys/arm/include/kdb.h
>   head/sys/arm/include/smp.h
> 
> Modified: head/sys/arm/include/kdb.h
> ==============================================================================
> --- head/sys/arm/include/kdb.h	Mon Jul 29 06:57:45 2013	(r253761)
> +++ head/sys/arm/include/kdb.h	Mon Jul 29 08:07:35 2013	(r253762)
> @@ -33,6 +33,8 @@
>  #include <machine/psl.h>
>  #include <machine/cpufunc.h>
>  
> +#define	KDB_STOPPEDPCB(pc)	&stoppcbs[pc->pc_cpuid]
> +
>  static __inline void
>  kdb_cpu_clear_singlestep(void)
>  {
> 
> Modified: head/sys/arm/include/smp.h
> ==============================================================================
> --- head/sys/arm/include/smp.h	Mon Jul 29 06:57:45 2013	(r253761)
> +++ head/sys/arm/include/smp.h	Mon Jul 29 08:07:35 2013	(r253762)
> @@ -32,4 +32,7 @@ void	platform_mp_init_secondary(void);
>  
>  void	platform_ipi_send(cpuset_t cpus, u_int ipi);
>  
> +/* global data in mp_machdep.c */
> +extern struct pcb               stoppcbs[];
> +
>  #endif /* !_MACHINE_SMP_H_ */

Hello Olivier,

This commit breaks kernel build for ARM.
I believe, you should have added:

#include <machine/pcb.h>

to: sys/arm/include/smp.h

Best regards
Zbyszek Bodek



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51F66459.7000500>