Date: Fri, 29 Mar 2024 18:49:15 +0300 From: Michael Zhilin <mizhka@gmail.com> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, lwhsu@freebsd.org Subject: Re: git: 9784fb237cdf - main - cad/libbgcode: new port Message-ID: <CAF19XB%2Bm8cd8nAqtBkZRrEf2rmv2Cm1yoOOyQOTFSjgmsp7m%2Bw@mail.gmail.com> In-Reply-To: <9e4f95a9f17095b157b809e469495723@mail.infomaniak.com> References: <202403281937.42SJbYnV072687@gitrepo.freebsd.org> <9e4f95a9f17095b157b809e469495723@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Thank you, Daniel! I'll try to follow the handbook as it's very cool. Fixed. Best regards, Michael On Fri, Mar 29, 2024 at 12:36 PM Daniel Engberg < daniel.engberg.lists@pyret.net> wrote: > On 2024-03-28T20:37:34.000+01:00, Michael Zhilin <mizhka@FreeBSD.org> > wrote: > > The branch main has been updated by mizhka: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=9784fb237cdf00b5f379c90df5c2d9f2bec97ea3 > > > > commit 9784fb237cdf00b5f379c90df5c2d9f2bec97ea3 > > Author: Michael Zhilin <mizhka@FreeBSD.org> > > AuthorDate: 2024-03-06 19:53:23 +0000 > > Commit: Michael Zhilin <mizhka@FreeBSD.org> > > CommitDate: 2024-03-28 19:31:42 +0000 > > > > cad/libbgcode: new port > > > > It is required by PrusaSlicer 2.7+. This port provides library and > > binary to work with g-code (read/write/convert) > > > > Reported by: Teodor Sigaev <teodorsigaev@gmail.com> > > Reviewed by: lwhsu (mentor) > > Sponsored by: Postgres Professional > > Differential Revision: https://reviews.freebsd.org/D44257 > > --- > > cad/Makefile | 1 + > > cad/libbgcode/Makefile | 27 > ++++++++++++++++++++++ > > cad/libbgcode/distinfo | 5 ++++ > > cad/libbgcode/files/patch-CMakeLists.txt | 13 +++++++++++ > > cad/libbgcode/files/patch-deps_CMakeLists.txt | 23 > ++++++++++++++++++ > > .../files/patch-deps_heatshrink_heatshrink.cmake | 12 ++++++++++ > > cad/libbgcode/pkg-descr | 2 ++ > > cad/libbgcode/pkg-plist | 21 > +++++++++++++++++ > > 8 files changed, 104 insertions(+) > > > > diff --git a/cad/Makefile b/cad/Makefile > > index e85ed462ada0..f43f0c101c4f 100644 > > --- a/cad/Makefile > > +++ b/cad/Makefile > > @@ -74,6 +74,7 @@ > > SUBDIR += ldview > > SUBDIR += leocad > > SUBDIR += lepton-eda > > + SUBDIR += libbgcode > > SUBDIR += libgdsii > > SUBDIR += libopencad > > SUBDIR += librecad > > diff --git a/cad/libbgcode/Makefile b/cad/libbgcode/Makefile > > new file mode 100644 > > index 000000000000..ffa5500927c5 > > --- /dev/null > > +++ b/cad/libbgcode/Makefile > > @@ -0,0 +1,27 @@ > > +PORTNAME= libbgcode > > +DISTVERSION= 0.2.0 > > +CATEGORIES= cad > > + > > +MAINTAINER= teodorsigaev@gmail.com > > +COMMENT= Prusa Block & Binary G-code reader/writer/converter > > +WWW= https://github.com/prusa3d/libbgcode > > + > > +LICENSE= AGPLv3 > > +LICENSE_FILE= ${WRKSRC}/LICENSE > > + > > +LIB_DEPENDS= libboost_nowide.so:devel/boost-libs > > + > > +USES= cmake > > + > > +USE_GITHUB= yes > > +GH_ACCOUNT= prusa3d > > +GH_TAGNAME= 6f43cb004ef3d3bda37dde49f6235e24d2717629 > > +GH_TUPLE= atomicobject:heatshrink:v0.4.1:heatshrink > > + > > +CMAKE_ARGS+= -DBUILD_SHARED_LIBS=ON \ > > + -DLibBGCode_BUILD_DEPS=ON \ > > + -DLibBGCode_BUILD_TESTS=OFF > > + > ... > > Hi, > > Please try to follow Poters Handbook, > (GH_TAGNAME should use short hash) > > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > > CMAKE_ARGS+= should be CMAKE_ARGS= and you can also use CMAKE_OFF and > CMAKE_ON instead which probably is a bit cleaner. > https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake > > Best regards, > Daniel (diizzy@) > [-- Attachment #2 --] <div dir="ltr"><div>Thank you, Daniel! </div><div>I'll try to follow the handbook as it's very cool.<br></div><div><br></div><div>Fixed. <br></div><div><br></div><div>Best regards,</div><div> Michael</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 29, 2024 at 12:36 PM Daniel Engberg <<a href="mailto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2024-03-28T20:37:34.000+01:00, Michael Zhilin <mizhka@FreeBSD.org> wrote:<br> > The branch main has been updated by mizhka:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=9784fb237cdf00b5f379c90df5c2d9f2bec97ea3" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=9784fb237cdf00b5f379c90df5c2d9f2bec97ea3</a><br>; > <br> > commit 9784fb237cdf00b5f379c90df5c2d9f2bec97ea3<br> > Author: Michael Zhilin <mizhka@FreeBSD.org><br> > AuthorDate: 2024-03-06 19:53:23 +0000<br> > Commit: Michael Zhilin <mizhka@FreeBSD.org><br> > CommitDate: 2024-03-28 19:31:42 +0000<br> > <br> > cad/libbgcode: new port<br> > <br> > It is required by PrusaSlicer 2.7+. This port provides library and<br> > binary to work with g-code (read/write/convert)<br> > <br> > Reported by: Teodor Sigaev <<a href="mailto:teodorsigaev@gmail.com" target="_blank">teodorsigaev@gmail.com</a>><br> > Reviewed by: lwhsu (mentor)<br> > Sponsored by: Postgres Professional<br> > Differential Revision: <a href="https://reviews.freebsd.org/D44257" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D44257</a><br>; > ---<br> > cad/Makefile | 1 +<br> > cad/libbgcode/Makefile | 27 ++++++++++++++++++++++<br> > cad/libbgcode/distinfo | 5 ++++<br> > cad/libbgcode/files/patch-CMakeLists.txt | 13 +++++++++++<br> > cad/libbgcode/files/patch-deps_CMakeLists.txt | 23 ++++++++++++++++++<br> > .../files/patch-deps_heatshrink_heatshrink.cmake | 12 ++++++++++<br> > cad/libbgcode/pkg-descr | 2 ++<br> > cad/libbgcode/pkg-plist | 21 +++++++++++++++++<br> > 8 files changed, 104 insertions(+)<br> > <br> > diff --git a/cad/Makefile b/cad/Makefile<br> > index e85ed462ada0..f43f0c101c4f 100644<br> > --- a/cad/Makefile<br> > +++ b/cad/Makefile<br> > @@ -74,6 +74,7 @@<br> > SUBDIR += ldview<br> > SUBDIR += leocad<br> > SUBDIR += lepton-eda<br> > + SUBDIR += libbgcode<br> > SUBDIR += libgdsii<br> > SUBDIR += libopencad<br> > SUBDIR += librecad<br> > diff --git a/cad/libbgcode/Makefile b/cad/libbgcode/Makefile<br> > new file mode 100644<br> > index 000000000000..ffa5500927c5<br> > --- /dev/null<br> > +++ b/cad/libbgcode/Makefile<br> > @@ -0,0 +1,27 @@<br> > +PORTNAME= libbgcode<br> > +DISTVERSION= 0.2.0<br> > +CATEGORIES= cad<br> > +<br> > +MAINTAINER= <a href="mailto:teodorsigaev@gmail.com" target="_blank">teodorsigaev@gmail.com</a><br> > +COMMENT= Prusa Block & Binary G-code reader/writer/converter<br> > +WWW= <a href="https://github.com/prusa3d/libbgcode" rel="noreferrer" target="_blank">https://github.com/prusa3d/libbgcode</a><br>; > +<br> > +LICENSE= AGPLv3<br> > +LICENSE_FILE= ${WRKSRC}/LICENSE<br> > +<br> > +LIB_DEPENDS= libboost_nowide.so:devel/boost-libs<br> > +<br> > +USES= cmake<br> > +<br> > +USE_GITHUB= yes<br> > +GH_ACCOUNT= prusa3d<br> > +GH_TAGNAME= 6f43cb004ef3d3bda37dde49f6235e24d2717629<br> > +GH_TUPLE= atomicobject:heatshrink:v0.4.1:heatshrink<br> > +<br> > +CMAKE_ARGS+= -DBUILD_SHARED_LIBS=ON \<br> > + -DLibBGCode_BUILD_DEPS=ON \<br> > + -DLibBGCode_BUILD_TESTS=OFF<br> > +<br> ...<br> <br> Hi,<br> <br> Please try to follow Poters Handbook,<br> (GH_TAGNAME should use short hash)<br> <a href="https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github" rel="noreferrer" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github</a><br>; <br> CMAKE_ARGS+= should be CMAKE_ARGS= and you can also use CMAKE_OFF and CMAKE_ON instead which probably is a bit cleaner.<br> <a href="https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake" rel="noreferrer" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake</a><br>; <br> Best regards,<br> Daniel (diizzy@)<br> </blockquote></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF19XB%2Bm8cd8nAqtBkZRrEf2rmv2Cm1yoOOyQOTFSjgmsp7m%2Bw>