Date: Tue, 5 Jan 2021 17:22:22 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: rgrimes@freebsd.org Cc: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2d486ba15f33 - main - pkgbase: Move bectl to the runtime package Message-ID: <20210105172222.f967fd57a637287a1a3d778a@bidouilliste.com> In-Reply-To: <202101051554.105FsFL7008161@gndrsh.dnsmgr.net> References: <20210104220959.fb00d9ec75b43c3ed580ae37@bidouilliste.com> <202101051554.105FsFL7008161@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 5 Jan 2021 07:54:15 -0800 (PST) "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> wrote: > > On Mon, 4 Jan 2021 12:58:58 -0800 (PST) > > "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> wrote: > > > > > > On Mon, 4 Jan 2021 12:49:19 -0800 (PST) > > > > "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> wrote: > > > > > > > > > > The branch main has been updated by manu: > > > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d486ba15f3367072d631ee588192ef46687fa4b > > > > > > > > > > > > commit 2d486ba15f3367072d631ee588192ef46687fa4b > > > > > > Author: Emmanuel Vadot <manu@freebsd.org> > > > > > > AuthorDate: 2020-12-21 15:00:02 +0000 > > > > > > Commit: Emmanuel Vadot <manu@FreeBSD.org> > > > > > > CommitDate: 2021-01-04 15:17:12 +0000 > > > > > > > > > > > > pkgbase: Move bectl to the runtime package > > > > > > > > > > > > runtime contain what is needed to boot in single user and repair a > > > > > > system, bectl could be handy to have in this situation. > > > > > > > > > > I would think it belongs in the zfs package, > > > > > as unless you have zfs you do not need bectrl. > > > > > > > > There is no zfs package. > > > > > > I would consider that an oversight. > > > > I don't. We don't have a ufs package for example. > > My understanding of the "big idea" of pkg base is to fine > grain feature install/removal, and I would consider support > for things like nfs, ufs, zfs to be along those lines > of fine grain. There is some limit to the fine grain. We started like that and we had 900+ packages, a lot of people didn't liked that. We're now at 293 packages (68 if you don't count the -dbg, -dev, -lib32 which won't be installed on most user machines). We still split part of the system into packages and I think that putting all the nfs tools might be a good idea (the same is true for a lot of binaries/libs present in the utilities package and a bit for some in the runtime one). > > > > > > Having zfs is controlled by WITH/WITHOUT_ZFS and this is not related > > > > to pkgbase. > > > > > > WITH/WITHOUT are compile time constructs, pkgbase is an install time > > > set of tools, why can there not be a zfs pkg? > > > > pkgbase is just a reflection of what is built. There can be a zfs > > package nothing prevent us for having one. But as said in the commit > > Great, then why dont we? And to your "ufs" above could that be > added as well? I don't think that having those binaries in their own package adds some advantages, even worse I think it's bad from a user point of view. There is honestly more important work to do for pkgbase than arguing about which packages should contain which files. I suggest you try pkgbase and see what you don't like about the organization and send a mail to pkgbase@f.o after. Cheers, > > runtime is the package that should contain everything needed for > > booting to single user and repair a system so it contain zfs related > > tools (and ufs ones). > > I thought the runtime package was the bits you MUST have to > build a running system, and nothing more. Perhaps I have > misunderstood. > > > > The idea behind runtime is that if you start upgrading and things > > break just after it you have all the tools to repair an install. > > I would of called that the "systemrepair" package. > > > > > > > > > > > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D27708 > > > > > > --- > > > > > > lib/libbe/Makefile | 1 + > > > > > > sbin/bectl/Makefile | 1 + > > > > > > 2 files changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/lib/libbe/Makefile b/lib/libbe/Makefile > > > > > > index 291e2438ee2a..d1fab41578bf 100644 > > > > > > --- a/lib/libbe/Makefile > > > > > > +++ b/lib/libbe/Makefile > > > > > > @@ -4,6 +4,7 @@ SHLIBDIR?= /lib > > > > > > > > > > > > .include <src.opts.mk> > > > > > > > > > > > > +PACKAGE= runtime > > > > > > LIB= be > > > > > > SHLIB_MAJOR= 1 > > > > > > SHLIB_MINOR= 0 > > > > > > diff --git a/sbin/bectl/Makefile b/sbin/bectl/Makefile > > > > > > index 6fa84f48661d..46d43306b9ca 100644 > > > > > > --- a/sbin/bectl/Makefile > > > > > > +++ b/sbin/bectl/Makefile > > > > > > @@ -2,6 +2,7 @@ > > > > > > > > > > > > .include <src.opts.mk> > > > > > > > > > > > > +PACKAGE=runtime > > > > > > PROG= bectl > > > > > > MAN= bectl.8 > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Rod Grimes rgrimes@freebsd.org > > > > > > > > > > > > -- > > > > Emmanuel Vadot <manu@bidouilliste.com> > > > > > > > > > > -- > > > Rod Grimes rgrimes@freebsd.org > > > > > > -- > > Emmanuel Vadot <manu@bidouilliste.com> > > > > -- > Rod Grimes rgrimes@freebsd.org -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210105172222.f967fd57a637287a1a3d778a>