Date: Sun, 4 Mar 2001 05:06:55 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: audit@FreeBSD.ORG, bde@FreeBSD.ORG Subject: Re: -Wnon-const-format patches, Pt 1 Message-ID: <20010304050655.A32634@mollari.cthul.hu> In-Reply-To: <xzpitlpit3t.fsf@flood.ping.uio.no>; from des@ofug.org on Sun, Mar 04, 2001 at 02:03:34PM %2B0100 References: <20010303151334.A33979@mollari.cthul.hu> <xzpitlpit3t.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Mar 04, 2001 at 02:03:34PM +0100, Dag-Erling Smorgrav wrote: > Kris Kennaway <kris@obsecurity.org> writes: > > These are the patches I have so far for format string warnings with > > -Wnon-const-format, covering the bin/ tree. Please review (especially > > whether I've got all the __printflike/__printf0like attributes correct > > -- the difference being whether the function gracefully handles a NULL > > format string, like the err() family, or through explicit checks). > > How about defining a wrapper macro for __printflike() that's empty > except when compiling with GCC? I know there are other issues that > prevent us from building our sources with other compilers, but there's > no reason to add yet another. __printflike/__printf0like is already a macro - see <sys/cdefs.h> Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6oj3uWry0BWjoQKURAhbuAJ9BFXmArB7NN9+f4y+akaRYYU1l1gCfXrh0 45su+8TEONE4/IbG5jT2CZQ= =f0om -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010304050655.A32634>