Date: Mon, 17 Oct 2011 19:12:46 +0200 From: Roman Divacky <rdivacky@freebsd.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: freebsd-toolchain@freebsd.org Subject: Re: [toolchain] disable -Wtautological-compare for clang Message-ID: <20111017171246.GA4161@freebsd.org> In-Reply-To: <alpine.LNX.2.00.1110170955060.2807@gerinyyl.fvgr> References: <20111017152548.GA66978@freebsd.org> <alpine.LNX.2.00.1110170955060.2807@gerinyyl.fvgr>
index | next in thread | previous in thread | raw e-mail
On Mon, Oct 17, 2011 at 09:56:23AM -0700, Gerald Pfeifer wrote: > On Mon, 17 Oct 2011, Alexander Best wrote: > > any chance we could disable -Wtautological-compare for clang? i don't > > think comparing an unsigned int against < 0 is worth a warning. actually > > it's always nice to have such a seatbelt, in case somebody changes the > > type to int and forgets to introduce such a check. > > I am on the fence on this one, for when I used the equivalent warning > in GCC this did found a number of real issues that I then addressed for > Wine (as an example). I also think this warning is very useful. Even in the "< 0" case, just think of the case when one meant "> 0" but typed the opposite. romanhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111017171246.GA4161>