Date: Wed, 16 Apr 2014 10:51:24 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: FreeBSD Net <freebsd-net@freebsd.org>, Hiroki Sato <hrs@FreeBSD.org> Subject: Re: route(8) fix Message-ID: <20140416065124.GZ902@glebius.int.ru> In-Reply-To: <CFF66C95-C9A6-40F2-89B7-470BEDC8D91B@FreeBSD.org> References: <CFF66C95-C9A6-40F2-89B7-470BEDC8D91B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 15, 2014 at 10:45:27PM +0000, Bjoern A. Zeeb wrote: B> can someone please review the below patch and see if it’s correct? B> I did a simple 1:1 replacement without thinking about the code. B> B> ! When switching variables to flags in r243185 a few cases were missed. B> ! After r263152 this leaves unused variables if route(8) is compiled B> ! without INET support. B> B> https://people.freebsd.org/~bz/20140415-01-sbin-route.diff Looks entirely correct and probably should fix some bugs. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140416065124.GZ902>