Date: Tue, 08 Jul 2008 00:26:31 +0700 From: Max Khon <fjoe@samodelkin.net> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: Max Khon <fjoe@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/dmucs Makefile ports/devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h patch-dmucs_msg.cc patch-main.cc Message-ID: <487251C7.7060102@samodelkin.net> In-Reply-To: <48724635.80406@FreeBSD.org> References: <200807071617.m67GHsHA058914@repoman.freebsd.org> <48724635.80406@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello! Pietro Cerutti wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Max Khon wrote: > | fjoe 2008-07-07 16:17:54 UTC > | > | FreeBSD ports repository > | > | Modified files: > | devel/dmucs Makefile > | Added files: > | devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h > | patch-dmucs_msg.cc patch-main.cc > | Log: > | Unbreak on 64-bit archs > > I definitely do not agree. Please note that a pointer is not required to > fit into a long, while it is required to fit into a size_t. > > Your solution may work as soon as we are concerned only with LP64 > machines. As soon as a LLP64 arch steps in, you break things. AFAIK it is not guaranteed that sizeof(void *) <= sizeof(size_t) too. I used "long" because I did not want to cope with "[u]intptr_t" there. Ok, I committed a modified patch that uses "const void *" instead of "long". /fjoe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?487251C7.7060102>