Date: Fri, 17 Aug 2018 11:25:48 +0100 From: Li-Wen Hsu <lwhsu@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... Message-ID: <CAKBkRUzGkKj5s2V9SW=v4BzOH0nb%2BXQaxFbot8nePDE6KEx9yA@mail.gmail.com> In-Reply-To: <3ffeebe7-07c5-bab2-d8c6-45d48adf662f@FreeBSD.org> References: <201808170023.w7H0Np0H027296@repo.freebsd.org> <3ffeebe7-07c5-bab2-d8c6-45d48adf662f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 17, 2018 at 7:26 AM John Baldwin <jhb@freebsd.org> wrote: > > On 8/17/18 1:23 AM, Conrad Meyer wrote: > > Author: cem > > Date: Fri Aug 17 00:23:50 2018 > > New Revision: 337936 > > URL: https://svnweb.freebsd.org/changeset/base/337936 > > > > Log: > > Bring in libsodium to sys/contrib > > > > Bring in https://github.com/jedisct1/libsodium at > > 461ac93b260b91db8ad957f5a576860e3e9c88a1 (August 7, 2018), unmodified. > > > > libsodium is derived from Daniel J. Bernstein et al.'s 2011 NaCl > > ("Networking and Cryptography Library," pronounced "salt") software library. > > At the risk of oversimplifying, libsodium primarily exists to make it easier > > to use NaCl. NaCl and libsodium provide high quality implementations of a > > number of useful cryptographic concepts (as well as the underlying > > primitics) seeing some adoption in newer network protocols. > > > > I considered but dismissed cleaning up the directory hierarchy and > > discarding artifacts of other build systems in favor of remaining close to > > upstream (and easing future updates). > > > > Nothing is integrated into the build system yet, so in that sense, no > > functional change. > > Can you import this into the vendor area and then do a bootstrap of > mergeinfo to sys/contrib? This permits future updates to use svn to > merge instead of doing it by hand. It also permits future imports to > be done by other developers following our standard, documented process > for working with third-party code. There are some files like `builds/msvc/*` probably not very useful for FreeBSD. I might be good to have these files listed in FREEBSD-Xlist and excluded from importing. Best, Li-Wen -- Li-Wen Hsu <lwhsu@FreeBSD.org> https://lwhsu.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUzGkKj5s2V9SW=v4BzOH0nb%2BXQaxFbot8nePDE6KEx9yA>