Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Mar 2025 20:44:13 +0000
From:      Brooks Davis <brooks@freebsd.org>
To:        Chuck Silvers <chs@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 623be660fcc9 - main - beep: add missing include of src.opts.mk, use LIBADD instead of LDFLAGS
Message-ID:  <Z9ssnc_6nT_NGUg6@spindle.one-eyed-alien.net>
In-Reply-To: <202503192022.52JKMaUG019132@gitrepo.freebsd.org>
References:  <202503192022.52JKMaUG019132@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 19, 2025 at 08:22:36PM +0000, Chuck Silvers wrote:
> The branch main has been updated by chs:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=623be660fcc9860c0e8b99e8c2c4bbdefc121fd1
> 
> commit 623be660fcc9860c0e8b99e8c2c4bbdefc121fd1
> Author:     Chuck Silvers <chs@FreeBSD.org>
> AuthorDate: 2025-03-19 19:48:10 +0000
> Commit:     Chuck Silvers <chs@FreeBSD.org>
> CommitDate: 2025-03-19 19:48:10 +0000
> 
>     beep: add missing include of src.opts.mk, use LIBADD instead of LDFLAGS
>     
>     Sponsored by:   Netflix
> ---
>  usr.bin/beep/Makefile | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/usr.bin/beep/Makefile b/usr.bin/beep/Makefile
> index f252ab64f843..8388ff7ff986 100644
> --- a/usr.bin/beep/Makefile
> +++ b/usr.bin/beep/Makefile
> @@ -1,6 +1,7 @@
> +.include <src.opts.mk>

Why add src.opts.mk?  Nothing is using it and bsd.prog.mk will include
it.  Is there another change coming that will use it?

-- Brooks

> +
>  PROG=	beep
>  MAN=	beep.1
> -
> -LDFLAGS= -lm
> +LIBADD=	m
>  
>  .include <bsd.prog.mk>
> 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z9ssnc_6nT_NGUg6>