Date: Wed, 30 May 2001 22:34:46 -0400 (EDT) From: Mike Heffner <mheffner@novacoxmail.com> To: Mike Barcroft <mike@q9media.com> Cc: phk@freebsd.org, freebsd-audit@freebsd.org Subject: RE: whois(1) patch Message-ID: <XFMail.20010530223446.mheffner@novacoxmail.com> In-Reply-To: <B739651A.B9D%mike@q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format --_=XFMail.1.4.7.FreeBSD:20010530223446:495=_ Content-Type: text/plain; charset=us-ascii On 29-May-2001 Mike Barcroft wrote: | | Please review the patch at the following URL: | http://testbed.q9media.net/freebsd/whois.patch | | | It does the following: | | o Silence warnings and set WARNS=2 | o Fix two memory leaks | o asprint -> strdup where appropriate | o calloc/strcpy/strcat -> aprintf | o Convert to ANSI C to avoid having to prototype main() You don't need the space between (void) and asprintf(). Also, I think dd had a patch for gcc to quiet the warning about main() not having a prototype, so I don't know if the ANSI-fication is truly needed. Otherwise, looks alright ;) Mike -- Mike Heffner <mheffner@vt.edu> Fredericksburg, VA <mikeh@FreeBSD.org> http://filebox.vt.edu/users/mheffner --_=XFMail.1.4.7.FreeBSD:20010530223446:495=_ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7Fa3FFokZQs3sv5kRAhvyAJ0cPsKqhzBNkw8v4CXqi9RVA8LJMwCgkKLD i9HNo2yIHd62cxQC4B5r8QM= =8m0m -----END PGP SIGNATURE----- --_=XFMail.1.4.7.FreeBSD:20010530223446:495=_-- End of MIME message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010530223446.mheffner>