Date: Mon, 29 May 2006 15:45:33 GMT From: Ruslan Ermilov <ru@FreeBSD.org> To: ru@FreeBSD.org, freebsd-bugs@FreeBSD.org, scottl@FreeBSD.org Subject: Re: kern/98091: [ patch ] Makefile style of mfi kernel module broke the WARNS/NO_WERROR logic Message-ID: <200605291545.k4TFjX1R057760@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [ patch ] Makefile style of mfi kernel module broke the WARNS/NO_WERROR logic
Responsible-Changed-From-To: freebsd-bugs->scottl
Responsible-Changed-By: ru
Responsible-Changed-When: Mon May 29 15:40:27 UTC 2006
Responsible-Changed-Why:
Scott, please fix it as per style.Makefile manpage:
o Do not use GCCisms (such as -g and -Wall) in CFLAGS.
o WARNS comes before CFLAGS, as it is basically a CFLAGS modifier. It
comes before CFLAGS rather than after CFLAGS so it does not get lost
in a sea of CFLAGS statements as WARNS is an important thing. The
usage of WARNS is spelled ``WARNS?= '', so that it may be overridden
on the command line or in make.conf(5).
http://www.freebsd.org/cgi/query-pr.cgi?pr=98091
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605291545.k4TFjX1R057760>