Date: Wed, 22 Feb 2006 15:18:51 +0100 From: Divacky Roman <xdivac02@stud.fit.vutbr.cz> To: Doug Barton <dougb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: Bad code in rcorder(8) (Was: Re: New RCorder: abi loaded too late) Message-ID: <20060222141851.GA43749@stud.fit.vutbr.cz> In-Reply-To: <43FBC1E4.7020204@FreeBSD.org> References: <20060217181842.GA21033@odin.ac.hmc.edu> <43F65A70.7080608@FreeBSD.org> <20060217234118.GA22643@odin.ac.hmc.edu> <43F67121.5080809@FreeBSD.org> <43F682F2.1020804@FreeBSD.org> <43F68611.7080602@FreeBSD.org> <20060219110732.GA12550@stud.fit.vutbr.cz> <43F8ABC8.30005@FreeBSD.org> <20060221180440.GB2996@galgenberg.net> <43FBC1E4.7020204@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 21, 2006 at 05:44:04PM -0800, Doug Barton wrote: > Ulrich Spoerlein wrote: > > >> Divacky Roman wrote: > >>> I tried running rcorder under valgrind and it showed me massive > >>> leaks/double-frees etc. unfortunately I am not able to run valgrind on recent > >>> 7-current (when I start it it just creates 2.8G coredump) > > > Looks fine to me ... > > I think the trick is to repeat your test with some bad stuff in the scripts. > So, create some circular dependencies, and some other impossible conditions, > then repeat the test. yes... I tried running valgrind on circular dependancies... that showed some mem leaks.... see http://www.freebsd.org/cgi/query-pr.cgi?pr=91789, I got that leaks when investigating this PR (iirc) > Also, Divacky posted a PR with a start to cleaning up the code, might be > worth some before and after on that. > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/93630 my patch doesnt solve any such problems. its just a little cleanup I did when looking at the code.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060222141851.GA43749>