Date: Thu, 7 Mar 2024 15:15:30 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Fernando =?utf-8?Q?Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> Cc: Daniel Engberg <daniel.engberg.lists@pyret.net>, Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN Message-ID: <ulhaktj3yz6yqkvwdz7wmhjqvgf736m2ehxfqst6vkdikb7o4c@ncvnusw5efsa> In-Reply-To: <CAGwOe2adJ-rES4gpgj-4s8dmHEmrtzRZp%2B%2BmJPYs-LueR3piJQ@mail.gmail.com> References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <CAGwOe2ZE6huqiTAV6zUpJqG6NxmkE2ado2M3oskp972pvBa8DA@mail.gmail.com> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> <CAGwOe2adJ-rES4gpgj-4s8dmHEmrtzRZp%2B%2BmJPYs-LueR3piJQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--5ie7ycna73r3o3ys Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 07, 2024 at 12:22:09PM +0100, Fernando Apestegu=C3=ADa wrote: > On Wed, Mar 6, 2024 at 10:34=E2=80=AFPM Daniel Engberg < > daniel.engberg.lists@pyret.net> wrote: >=20 > > On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa < > > fernando.apesteguia@gmail.com> wrote: > > > On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg <diizzy@freebs= d.org> > > wrote: > > > > > > > > > > The branch main has been updated by diizzy: > > > > > > > > URL: > > > > > > https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a1621689= 02cebbca1f4c1 > > > > > > > > commit ea45a9a534994a1bf97a162168902cebbca1f4c1 > > > > Author: Daniel Engberg <diizzy@FreeBSD.org> > > > > AuthorDate: 2024-03-03 08:29:04 +0000 > > > > Commit: Daniel Engberg <diizzy@FreeBSD.org> > > > > CommitDate: 2024-03-03 19:26:10 +0000 > > > > > > > > cad/PrusaSlicer: Mark BROKEN > > > > > > > > Fails to build, error: no member named 'prior' in namespace > > 'boost' > > > > > > > > Reported by: pkg-fallout > > > > --- > > > > cad/PrusaSlicer/Makefile | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile > > > > index dc125244df20..936e76216daf 100644 > > > > --- a/cad/PrusaSlicer/Makefile > > > > +++ b/cad/PrusaSlicer/Makefile > > > > @@ -12,6 +12,8 @@ WWW=3D https://www.prusa3d.com/prusasli= cer/ > > > > LICENSE=3D AGPLv3 > > > > LICENSE_FILE=3D ${WRKSRC}/LICENSE > > > > > > > > +BROKEN=3D fails to build, error: no member named > > 'prior' in > > > > namespace 'boost' > > > > + > > > > > > > > > > Can we revert this? > > > It is an issue with math/cgal and not cad/PrusaSlicer ( > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277480) > > > > > > > Cheers. > > > > > > > > > > > > > BUILD_DEPENDS=3D cereal>=3D1.3.0.10:devel/cereal \ > > > > cgal>=3D5.0.2:math/cgal \ > > > > opencascade>=3D7.7.0:cad/opencascade > > > > > > > Hi, > > > > It breaks Prusaslicer either way? > > > > https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/err= ors/PrusaSlicer-2.6.0_8.log >=20 >=20 > I just realized I didn't attach the patch to the PR :S > It is attached now. > With that patch in math/cgal, cad/PrusaSlicer builds fine. >=20 > My main point is this. We should mark ports as BROKEN when *they* are > broken, not when the dependencies are. In this case, the dependency was not broken in the sense that it built just fine. We mark ports BROKEN because they don't build, so that the FreeBSD ports infrastructure does not spend hours trying to build stuff that will never build. --=20 Mathieu Arnold --5ie7ycna73r3o3ys Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXpzABfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6TAgv/X7jJeMdimL+NAvs4dgrQQ2aBjx2IrVwU/pMOdS0Q55q1cdl5ZBefEUEY vAxjX5YUVQArADCFd1J2lFPhHkkDhLoV6Sdb9di7oJWSETPwZNAeKLusru6PV31+ 86deunEjh13rH+r8qUAbEjbz46vbnl9pmSqRp1MUTUZHnRbeIiS99PtGqjr2Zl6w /GSyZQg+LMyXfucrSofNvLDo9KQN5zkbSgB55Lww0Xa0//9jgibwT1wlE0HmN1UO HYPbFdKMXjLX+Fm409rDkk0M5gMTGVMb/IJmCvqvjJMJ1OAUggIv76eS0rAL/97X HfY3LGA+0sa0ceulZQFY+yXrkd4ISl4wig3XDDzkzIULsdjeD9wHuomMvZBSN+LU dZvhPQ8ohfVvKburN2fUPDxREdgvbjArBeVuUPNLCJWKAeOKWD9AxVr4stuVAywE duigLCzeUgar3pw2ByKSDlZGWnNhoW4nhVDw7I7+uQ+qiS3ypRfV4/5lEGeNinFl IjNbM0pa =d/nT -----END PGP SIGNATURE----- --5ie7ycna73r3o3ys--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ulhaktj3yz6yqkvwdz7wmhjqvgf736m2ehxfqst6vkdikb7o4c>