Date: Mon, 13 Jul 2009 23:00:30 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Wesley Shields <wxs@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, "Rashid N. Achilov" <citycat4@ngs.ru>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/flowd Makefile ports/net-mgmt/flowd/files flowd.in Message-ID: <4A5C1EFE.5060609@FreeBSD.org> In-Reply-To: <200907131622.n6DGMuOa014201@repoman.freebsd.org> References: <200907131622.n6DGMuOa014201@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Wesley Shields wrote: > wxs 2009-07-13 16:22:56 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/flowd Makefile > Added files: > net-mgmt/flowd/files flowd.in > Log: > - Install RC script. > > PR: ports/135949 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=135949 > Submitted by: Rashid N. Achilov <citycat4@ngs.ru> > Approved by: maintainer timeout > > Revision Changes Path > 1.14 +2 -0 ports/net-mgmt/flowd/Makefile > 1.1 +30 -0 ports/net-mgmt/flowd/files/flowd.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/Makefile.diff?&r1=1.13&r2=1.14&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/files/flowd.in > Overall this looks quite good, thanks! The only thing I would change is to eliminate the empty _flags assignment, and include that in the example comments at the top. You might also want to s/ipcad/flowd/. :) hth, Doug
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A5C1EFE.5060609>