Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Mar 2011 18:17:12 +0100
From:      Roman Divacky <rdivacky@freebsd.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        freebsd-current@freebsd.org, current@freebsd.org
Subject:   Re: [TESTING]: boot2 changes
Message-ID:  <20110301171712.GA64489@freebsd.org>
In-Reply-To: <201103010754.14686.jhb@freebsd.org>
References:  <20110228203928.GA93494@freebsd.org> <201103010754.14686.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 01, 2011 at 07:54:14AM -0500, John Baldwin wrote:
> On Monday, February 28, 2011 3:39:28 pm Roman Divacky wrote:
> > 3) it changes the first keyhit limit to 5 seconds from 3
> >    so that constant propagation can take place
> 
> Does this make booting take 2 seconds longer as a result?
> 
> I'm curious as to why '3*FOO' isn't a constant but '5*FOO' is?

I worded it wrong, the point being that if the argument is the same
in all callsites the compiler can turn it into a constant and propagate
that to the function.

I will remove this as it saves just 8 bytes... thank you for the review!

roman



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110301171712.GA64489>