Date: Mon, 3 Feb 2003 15:07:40 +0200 From: Sheldon Hearn <sheldonh@starjuice.net> To: "Tim J. Robbins" <tjr@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh jobs.c Message-ID: <20030203130740.GI30972@starjuice.net> In-Reply-To: <200301270741.h0R7fCJe032467@repoman.freebsd.org> References: <200301270741.h0R7fCJe032467@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On (2003/01/26 23:41), Tim J. Robbins wrote: > Modified files: > bin/sh jobs.c > Log: > Ensure that the TTY file descriptor is greater than or equal to 10 so that > it doesn't interfere with the user's redirections. Could you add how the magic number 10 was calculated to the comment you inserted? Also, it may be better for the comment to appear before the first use of the magic number 10. Also, it may be better to use a macro to represent the magic number 10, since it's used multiple times. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030203130740.GI30972>