Date: Sun, 30 Mar 2003 11:28:09 -0800 From: Wes Peters <wes@softweyr.com> To: "M. Warner Losh" <imp@bsdimp.com>, net@freebsd.org Subject: Re: ifconfig question Message-ID: <200303301128.09717.wes@softweyr.com> In-Reply-To: <20030329.195108.133248709.imp@bsdimp.com> References: <20030329.195108.133248709.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 29 March 2003 18:51, M. Warner Losh wrote:
> The code that prints out the keys for the 802.11 wireless stuff has
> the following it it:
>
> void
> ieee80211_status (int s, struct rt_addrinfo *info __unused)
> {
> ...
> if (ireq.i_len == 0 || ireq.i_len > 13)
> continue;
> ...
> }
>
> Should that check really be there? Newer wep does 256bits.... Not
> that the rest of the code supports that, but I was just curious.
Only if the spec says those are the only valid ranges. Then we have to
keep up to date with changes in the spec, too. Either some simple sanity
checks or checking for truly valid lengths -- 0, 40 bits, 128 bits --
makes even better sense.
> Second, should ifconfig report the wep key if run as root? wicontrol
> does if it is run as root, for example. Any objections for fixing
> this?
That would be convenient.
--
Where am I, and what am I doing in this handbasket?
Wes Peters wes@softweyr.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303301128.09717.wes>