Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Sep 2010 15:41:48 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        src-committers@freebsd.org
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r213226 - head/sys/i386/i386
Message-ID:  <201009271541.48624.jhb@freebsd.org>
In-Reply-To: <201009271936.o8RJaG6J047624@svn.freebsd.org>
References:  <201009271936.o8RJaG6J047624@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, September 27, 2010 3:36:16 pm John Baldwin wrote:
> Author: jhb
> Date: Mon Sep 27 19:36:15 2010
> New Revision: 213226
> URL: http://svn.freebsd.org/changeset/base/213226
> 
> Log:
>   Rewrite the i386 memory probe:
>   - Check for SMAP data from the loader first.  If it exists, don't bother
>     doing any VM86 calls at all.  This will be more friendly for non-BIOS
>     boot environments such as EFI, etc.
>   - Move the base memory setup into a new basemem_setup() routine instead
>     of duplicating it.
>   - Simplify the XEN case by removing all of the VM86/SMAP parsing code rather
>     than just jumping over it.
>   - Adjust some comments to better explain the code flow.

This could maybe be cleaned up a bit further by splitting getmemsize() up
into two routines: one to populate physmap[], and one to do the rest.  Then
XEN could just have a separate routine for the first function for example.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009271541.48624.jhb>