Date: Tue, 13 Apr 2004 20:43:18 -0700 From: Tim Kientzle <tim@kientzle.com> To: Alfred Perlstein <alfred@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c Message-ID: <407CB356.7060102@kientzle.com> In-Reply-To: <20040414021526.GB63832@elvis.mu.org> References: <200404140040.i3E0esil061104@repoman.freebsd.org> <20040414021526.GB63832@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Huh? Maybe I'm missing something, but I don't see the instantiations to which you refer. I do see a lot of struct definitions, and a handful of function prototypes, but no variable declarations. If I messed up and did accidentally declare a variable, could you please point it out. I honestly can't see it. Tim Alfred Perlstein wrote: > While I applaud the effort here, it is a major violation of C > POLA to have compilable code within a header file. I think you > should basically move all the variables instantiated in bsdtar.h > to their appropriate .c files. > > thank you, > -Alfred > > * Tim Kientzle <kientzle@FreeBSD.org> [040413 17:41] wrote: > >>kientzle 2004/04/13 17:40:54 PDT >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/tar bsdtar.c bsdtar.h write.c >> Log: >> A simple cache of uid->uname lookups and gid->gname lookups eliminates >> almost 1/2 of the CPU time required to create an uncompressed archive >> and makes a noticable reduction in wallclock time. >> >> Revision Changes Path >> 1.6 +11 -0 src/usr.bin/tar/bsdtar.c >> 1.3 +14 -0 src/usr.bin/tar/bsdtar.h >> 1.7 +35 -12 src/usr.bin/tar/write.c > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?407CB356.7060102>