Date: Wed, 03 Jun 2026 18:06:05 +0200 From: Olivier Certner <olce@freebsd.org> To: Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Dag-Erling =?UTF-8?B?U23DuHJncmF2?= <des@freebsd.org> Subject: Re: git: 886164895f3f - main - amd64: complete thunderbolt KERNCONF integration Message-ID: <3174612.hHqAuc6tWs@ravel> In-Reply-To: <86wlwgue2o.fsf@ltc.des.dev> References: <6a1fc36c.20f4d.2792bff2@gitrepo.freebsd.org> <86wlwgue2o.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi Enji, > > commit 886164895f3f4805dc11171ac7980acaccf6ec77 > > Author: Enji Cooper <ngie@FreeBSD.org> > > AuthorDate: 2026-06-03 06:02:01 +0000 > > Commit: Enji Cooper <ngie@FreeBSD.org> > > CommitDate: 2026-06-03 06:02:01 +0000 > > > > amd64: complete thunderbolt KERNCONF integration > > > > This completes the work so the driver can be integrated into KERNCONFs > > properly on amd64. > > > > MFC after: 1 month > > > > Differential Revision: https://reviews.freebsd.org/D55573 > > /usr/src/sys/dev/thunderbolt/router.c:281:6: error: variable 'up' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/router.c:723:8: error: variable 'adap' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/nhi.c:837:20: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/nhi.c:871:20: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/nhi.c:874:8: error: variable 'len' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/tb_acpi_pcib.c:123:15: error: variable 's' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6: error: variable 'error' set but not used [-Werror,-Wunused-but-set-variable] Compilation fails on INVARIANTS, it works with !INVARIANTS. Was bitten by such a case relatively recently. Try not to forget to build both cases when fiddling with debug code. Fixed in 9a133eee1ed9cf32. Amend as you see fit. Regards. -- Olivier Certner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmogUO4ACgkQjKEwQJce JicLJw//YZNDyejTzZP88Uanm628qnXLWCczFy4qiJJ4WfhmfGahlnOq03uzBhwo w6ssuLyTXpMSmhYn2998I8LpDZNuv05QPRgi2MtmEUCTqDWCV/6ea3+/GmtMMpDT oo94moiprS26FWZE+n21+uYhmyKdPft5PrUyUmQQdDqHQutp6v6JjA4sYUn35HIQ BZ/ikShVvi0js2bxpQmOQiCpgXW1ZRSBkgWsPOoemBjnv2XyDzni9NQsc8fL+f4q GShYIvus2+gFIRYyNdP45aDaAu4mYwSPaD/8n13sk/EV3cBMKukPojPt7jDUMZw/ NgdcdcNtpT0F/VnMpRIg+00T7AezKOJBhdMoZPB67qGCININd4OkFQBlOqYwpnWJ meoN8/NjAKQBQuvXxA6B4/yk2OKwawSudKSwHeKfyJRLL74E2a77eJZ2EXP9M55P ctbKfIBDNws+vUqepnieA8wt8AXsLdEKm2+SnvblnFa2qNCk5dmyVUR4lqtVlFcc +DjA2noK9Y65i+teK1KZKKa/FIRd5tJiWrBfbQdQcWyxBFIl6dHZnsoy2w3aOH1z 9YL11SjemFxNTWef6ghWRy123MZIlspA3JADzQHIuzOeBxHDJGTuw73pV1WxikAK niMw1wN/XFLbCeQlKWDRaLJRv0GeUwT/GbR0uvPKP6tMzu3xi5M= =Fw5d -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3174612.hHqAuc6tWs>