Date: Wed, 26 Aug 1998 19:09:00 +1000 From: Stephen McKay <syssgm@dtir.qld.gov.au> To: Doug Rabson <dfr@nlsystems.com> Cc: freebsd-current@FreeBSD.ORG, syssgm@dtir.qld.gov.au Subject: Re: Serious bug in vm_page.h in current Message-ID: <199808260909.TAA11802@nymph.dtir.qld.gov.au> In-Reply-To: <Pine.BSF.4.01.9808260953170.17263-100000@herring.nlsystems.com> from Doug Rabson at "Wed, 26 Aug 1998 09:54:08 %2B0100" References: <Pine.BSF.4.01.9808260953170.17263-100000@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, 26th August 1998, Doug Rabson wrote:
>How about this:
>
>Index: vm_page.h
>===================================================================
>+static __inline void
>+vm_page_busy(vm_page_t m)
>+{
>+ vm_page_busy(m);
> }
An "oops"? Otherwise looking good.
But to be picky, I prefer vm_page_flag_clear() and vm_page_flag_set() to
vm_page_clear_flag() and vm_page_set_flag(). Similarly, I think that
vm_page_io_start() and vm_page_io_finish() would be better than
vm_page_start_io() and vm_page_finish_io(). I hope you can see my
reasoning.
But, I'm not going to arm wrestle you for it if you don't like it.
Stephen.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808260909.TAA11802>