Date: Mon, 11 Jun 2001 02:08:52 -0700 (PDT) From: Poul-Henning Kamp <phk@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern tty_pty.c Message-ID: <200106110908.f5B98qM07061@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
phk 2001/06/11 02:08:52 PDT
Modified files: (Branch: RELENG_4)
sys/kern tty_pty.c
Log:
MFC:
With the new kernel dev_t conversions done at release 4.X,
it becomes possible to trap in ptsstop() in kern/tty_pty.c
if the slave side has never been opened during the life of a kernel.
What happens is that calls to ttyflush() done from ptyioctl() for the
controlling side end up calling ptsstop() [via (*tp->t_stop)(tp, <X>)]
which evaluates the following:
struct pt_ioctl *pti = tp->t_dev->si_drv1;
In order for tp->t_dev to be set, the slave device must first be
opened in ttyopen() [kern/tty.c].
It appears that the only problem is calls to (*tp->t_stop)(tp, <n>),
so this could also happen with other ioctls initiated by the
controlling side before the slave has been opened.
Revision Changes Path
1.74.2.2 +2 -1 src/sys/kern/tty_pty.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106110908.f5B98qM07061>