Date: Mon, 25 Jan 2021 15:09:19 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Cy Schubert <cy@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 83edbc3cb54f - main - ipfilter: Retire pre-standard C support. Message-ID: <202101252309.10PN9JcL022164@slippy.cwsent.com> In-Reply-To: <B5F169E0-1553-4BAF-A4F5-5158A64FDA3C@freebsd.org> References: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> <B5F169E0-1553-4BAF-A4F5-5158A64FDA3C@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <B5F169E0-1553-4BAF-A4F5-5158A64FDA3C@freebsd.org>, Jessica Clarke w rites: > Hi, > > On 25 Jan 2021, at 22:47, Cy Schubert <cy@FreeBSD.org> wrote: > > > > diff --git a/contrib/ipfilter/ipf.h b/contrib/ipfilter/ipf.h > > index 05dcfa4afd64..834ba83f51f0 100644 > > --- a/contrib/ipfilter/ipf.h > > +++ b/contrib/ipfilter/ipf.h > > @@ -73,15 +73,7 @@ > > #include "opts.h" > > > > #ifndef __P > > -# ifdef __STDC__ > > # define __P(x) x > > There are a few cases like this where the indentation should be reduced > (or just removed if it's no longer so confusing). There are a number of those in ipfilter, currently. Rather than confuse the functional changes with aesthetic changes, which makes it difficult for people to bisect history, I'll push those prior to the next batch of functional changes. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101252309.10PN9JcL022164>