Date: Tue, 13 Apr 2010 10:18:48 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: svn-src-head@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, svn-src-all@FreeBSD.org Subject: Re: svn commit: r206497 - in head: sbin/geom/class sbin/geom/class/sched sys/geom/sched sys/modules/geom sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched sys/modules/geom/geom_sched/gsc... Message-ID: <445CC969-4E21-4EA8-BE19-1754F4B2C583@freebsd.org> In-Reply-To: <20100412210512.GB94885@onelab2.iet.unipi.it> References: <201004121637.o3CGbjSK080066@svn.freebsd.org> <20100412204926.GB1743@garage.freebsd.pl> <20100412210512.GB94885@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12 Apr 2010, at 22:05, Luigi Rizzo wrote:
> On Mon, Apr 12, 2010 at 10:49:26PM +0200, Pawel Jakub Dawidek wrote:
> ...
>>> @@ -0,0 +1,19 @@
>>> +# GEOM_LIBRARY_PATH
>>> +# $FreeBSD$
>>> +
>>> +.PATH: /usr/src/sbin/geom/misc
>>> +
>>> +CFLAGS += -I/usr/src/sbin/geom
>>
>> This doesn't look right.
>
> probably a leftover from older versions of this code for 6.x .
> I will do more tests tomorrow (for 7.x at this point, there is
> no point in trying to support 6.x I believe) and try to remove
> it if not necessary.
Even if you need geom/misc, this is not the correct way to include it.
M= ${.CURDIR}/../../misc
.PATH: ${M}
CFLAGS+=-I${M}
is probably what you want. There are many people out there (me included) that don't use /usr/src.
Regards,
--
Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?445CC969-4E21-4EA8-BE19-1754F4B2C583>