Date: Mon, 21 May 2001 09:24:59 +0200 From: Joachim =?iso-8859-1?Q?Str=F6mbergson?= <watchman@ludd.luth.se> To: Mike Heffner <mheffner@vt.edu> Cc: FreeBSD-Audit <audit@FreeBSD.ORG> Subject: Re: Patch to add nic-se to whois Message-ID: <3B08C2CB.2ABF2EF2@ludd.luth.se> References: <XFMail.20010520185911.spock@techfour.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Aloha!
Mike Heffner wrote:
> Except for breaking style(9) (spaces instead of tabs), it looks alright. Also,
> don't forget to update whois.1.
Ok, fixed. Thanks!
Next stop will be the man page.
When talking about style here, I tried to insert the addition in
alphabetical order. Looking at the source for whois, some of the defines
for the other databases seems to have been added without taking care of
this:
#define NICHOST "whois.crsnic.net"
#define INICHOST "whois.networksolutions.com"
#define DNICHOST "whois.nic.mil"
#define GNICHOST "whois.nic.gov"
#define ANICHOST "whois.arin.net"
#define RNICHOST "whois.ripe.net"
#define PNICHOST "whois.apnic.net"
#define RUNICHOST "whois.ripn.net"
#define MNICHOST "whois.ra.net"
#define QNICHOST_TAIL ".whois-servers.net"
#define SENICHOST "whois.nic-se.se"
#define SNICHOST "whois.6bone.net"
Is this important and/or something we want? I checked man style(9) and
it seems to recommend sorting rules for includes and variables. I could
sort these if that would seem appropriate while I'm at it.
> | this something we should add to the system?
>
> Sure. Does this option, `s', conflict with any of the other BSDs?
Well the OpenBSD patch used 's' for this option. Dunno about NetBSD and
BSDi. I'll check.
--
Med vänlig hälsning, Cheers!
Joachim Strömbergson
============================================================================
Joachim Strömbergson - ASIC designer, nice to *cute* animals.
snail: phone: mail & web:
Sävenäsgatan 5A +46 31 - 27 98 47 watchman@ludd.luth.se
416 72 Göteborg +46 733 75 97 02
www.ludd.luth.se/~watchman
============================================================================
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B08C2CB.2ABF2EF2>