Date: Mon, 6 Mar 2017 21:06:19 +0000 From: "Somayajulu, David" <David.Somayajulu@cavium.com> To: "rgrimes@freebsd.org" <rgrimes@freebsd.org>, David C Somayajulu <davidcs@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-stable-11@freebsd.org" <svn-src-stable-11@freebsd.org> Subject: RE: svn commit: r314789 - stable/11/sys/dev/qlxgbe Message-ID: <BY2PR07MB14745C1D901D507F738809B9EE2C0@BY2PR07MB1474.namprd07.prod.outlook.com> In-Reply-To: <201703062053.v26KrG3S090402@pdx.rh.CN85.dnsmgr.net> References: <201703062025.v26KPYSZ043721@repo.freebsd.org> <201703062053.v26KrG3S090402@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Rodney, I was worried about the same as well. The reason it looks funky is that the= following two lines have a 8 spaces instead of a tab. > bus_dmamem_free(dma_buf->dma_tag, dma_buf->dma_b, dma_buf->dma_m= ap); > bus_dma_tag_destroy(dma_buf->dma_tag); While=20 > + bus_dmamap_unload(dma_buf->dma_tag, dma_buf->dma_map); Uses a tab instead.=20 Thanks David S. -----Original Message----- From: Rodney W. Grimes [mailto:freebsd@pdx.rh.CN85.dnsmgr.net]=20 Sent: Monday, March 06, 2017 12:53 PM To: David C Somayajulu <davidcs@freebsd.org> Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-stable@fre= ebsd.org; svn-src-stable-11@freebsd.org Subject: Re: svn commit: r314789 - stable/11/sys/dev/qlxgbe > Author: davidcs > Date: Mon Mar 6 20:25:33 2017 > New Revision: 314789 > URL: https://svnweb.freebsd.org/changeset/base/314789 >=20 > Log: > MFC r314062 > add bus_dmamap_unload in ql_free_dmabuf() >=20 > Modified: > stable/11/sys/dev/qlxgbe/ql_os.c > Directory Properties: > stable/11/ (props changed) >=20 > Modified: stable/11/sys/dev/qlxgbe/ql_os.c=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- stable/11/sys/dev/qlxgbe/ql_os.c Mon Mar 6 19:55:07 2017 (r314788) > +++ stable/11/sys/dev/qlxgbe/ql_os.c Mon Mar 6 20:25:33 2017 (r314789) > @@ -735,6 +735,7 @@ ql_alloc_dmabuf_exit: > void > ql_free_dmabuf(qla_host_t *ha, qla_dma_t *dma_buf) { > + bus_dmamap_unload(dma_buf->dma_tag, dma_buf->dma_map); > bus_dmamem_free(dma_buf->dma_tag, dma_buf->dma_b, dma_buf->dma_m= ap); > bus_dma_tag_destroy(dma_buf->dma_tag); > } That looks as if this file has incorrect leading white space? --=20 Rod Grimes rgrimes@freebsd.= org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BY2PR07MB14745C1D901D507F738809B9EE2C0>