Date: Thu, 18 Nov 1999 15:27:16 +0100 From: Alexander Langer <alex@cichlids.com> To: okimoto@mrit.mei.co.jp Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/14920: install(1) hangs when intalling files same directory. Message-ID: <19991118152716.A521@cichlids.cichlids.com> In-Reply-To: <199911181140.DAA22075@freefall.freebsd.org>; from okimoto@mrit.mei.co.jp on Thu, Nov 18, 1999 at 03:40:01AM -0800 References: <199911181140.DAA22075@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake okimoto@mrit.mei.co.jp (okimoto@mrit.mei.co.jp):
> He said this problem was 3.3-RELEASE case. But,
> install(1) should detect if the source-file is the
> same as the destination file, he also thought.
> So, he made a patch for "xinstall.c", and it's good.
Hello!
Actually, I'm redoing the patch, because it's not that good as it
seems.
Additionally, I found a strange bug:
root:/usr/src/usr.bin/xinstall $ install /dev/null /usr/home
install: /dev/null: Inappropriate file type or format
xinstall.c includes
/* If try to install NULL file to a directory, fails. */
if (flags & DIRECTORY || strcmp(from_name,
_PATH_DEVNULL)) {
The part in this brackets does not look senseful for me.
It should be (flags & DIRECTORY && strcmp(from_name, _PATH_DEVNULL) ==
0), at least with the stuff inside the brackets.
I'll redo this, too.
Alex
--
I doubt, therefore I might be.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991118152716.A521>