Date: Sun, 19 Jul 1998 11:48:51 -0700 (PDT) From: Anders.X.Thulin@telia.se To: freebsd-gnats-submit@FreeBSD.ORG Subject: bin/7319: routed/rtquery: bad pointer comparison Message-ID: <199807191848.LAA07743@hub.freebsd.org>
index | next in thread | raw e-mail
>Number: 7319
>Category: bin
>Synopsis: routed/rtquery: bad pointer comparison
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jul 19 11:50:01 PDT 1998
>Last-Modified:
>Originator: Anders Thulin
>Organization:
(none)
>Release: 2.2.6 (Walnut Creek CD)
>Environment:
FreeBSD myname.my.domain 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #0: Wed Mar 25 02:28:49 GMT 1998
jkh@time.cdrom.com:/usr/src/sys/compile/GENERIC i386
>Description:
/usr/src/sbin/routed/parms.c and .../routed/rtquery/rtquery.c both
contain code that compare a char pointer with a char.
As this doesn't make much sense, it looks very much as if a '*'
has been dropped by mistake.
I have made no analysis of the possible consequences of the problem.
>How-To-Repeat:
Not applicable -- I discovered the problem while linting the code.
>Fix:
.../routed/parms.c:
379c379
< if (c == '\\' && pc != '\0') {
---
> if (c == '\\' && *pc != '\0') {
.../routed/rtquery/rtquery.c:
809c809
< if (c == '\\' && pc != '\0') {
---
> if (c == '\\' && *pc != '\0') {
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199807191848.LAA07743>