Date: Wed, 14 Apr 2010 09:46:17 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: svn-src-head@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r206497 - in head: sbin/geom/class sbin/geom/class/sched sys/geom/sched sys/modules/geom sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched sys/modules/geom/geom_sched/gsc... Message-ID: <20100414074616.GA1657@garage.freebsd.pl> In-Reply-To: <20100412210512.GB94885@onelab2.iet.unipi.it> References: <201004121637.o3CGbjSK080066@svn.freebsd.org> <20100412204926.GB1743@garage.freebsd.pl> <20100412210512.GB94885@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
--cWoXeonUoKmBZSoM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Apr 12, 2010 at 11:05:12PM +0200, Luigi Rizzo wrote:
> On Mon, Apr 12, 2010 at 10:49:26PM +0200, Pawel Jakub Dawidek wrote:
> ...
> > > @@ -0,0 +1,19 @@
> > > +# GEOM_LIBRARY_PATH
> > > +# $FreeBSD$
> > > +
> > > +.PATH: /usr/src/sbin/geom/misc
> > > +
> > > +CFLAGS +=3D -I/usr/src/sbin/geom
> >=20
> > This doesn't look right.
>=20
> probably a leftover from older versions of this code for 6.x .
> I will do more tests tomorrow (for 7.x at this point, there is
> no point in trying to support 6.x I believe) and try to remove
> it if not necessary.
As Rui said you should use ${.CURDIR} instead of hardcoding /usr/src/.
BTW. So you decided to implement insert/remove functionality after all.
I have some questions:
- It is implemented as internal gsched hack, which is a pity, because
this might be very useful functionality for other classes in the future.
Is there a plan to make it more general and move it to the GEOM itself?
- Why g_sched_flush_pending() operates on global structure? I think it
will break if you try to insert and remove at the same time.
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
--cWoXeonUoKmBZSoM
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAkvFcsgACgkQForvXbEpPzSgTQCgk300EKdL36NzV2dwl5K2E59L
cA0AoMICf8zhh4mTBF6i9i4Gh5f1jD5t
=W8nO
-----END PGP SIGNATURE-----
--cWoXeonUoKmBZSoM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100414074616.GA1657>