Date: Sun, 14 Jun 2009 17:49:42 -0700 From: Sam Leffler <sam@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r194204 - in head/sys: amd64/conf i386/conf Message-ID: <4A359AA6.7010101@freebsd.org> In-Reply-To: <20090615075134.K24645@delplex.bde.org> References: <200906141801.n5EI1Zti056239@svn.freebsd.org> <4A356A0F.3050800@freebsd.org> <20090615075134.K24645@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote:
> On Sun, 14 Jun 2009, Sam Leffler wrote:
>
>>> Log:
>>> Enable PRINTF_BUFR_SIZE on i386 and amd64 by default.
>>>
>>> In the past there have been some reports of PRINTF_BUFR_SIZE not
>>> functioning correctly. Instead of having garbled console messages, we
>>> should just see whether the issues are still there and analyze them.
>>
>> When I suggested enabling this by default for SMP configurations I was
>> reminded it wasn't enabled because of potential stack overflow.
>
> Stack overflow shouldn't be a problem, since printf shouldn't be called
> recursively.
You don't need recursion to overflow the stack. I'd love to see someone
properly lock printf/console output instead of kludges like
PRINTF_BUFR_SIZE.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A359AA6.7010101>