Date: Sat, 1 Feb 2014 07:45:03 +0800 From: =?GB2312?Q?"=BB=C6=CE=C4=BB=D4=40Gmail"?= <huanghwh@gmail.com> To: Hans Petter Selasky <hps@bitfrost.no> Cc: "Danilo E. Gondolfo" <danilo@freebsd.org>, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: Apple Trackpad driver Message-ID: <38C22813-14E0-45A2-80CC-ED17525F6B95@gmail.com> In-Reply-To: <52EC2889.9020107@bitfrost.no> References: <CAB8uncaLEn4CaJv8%2BowESe_zUUK%2Bgem_bXpEjhsOJE69m_fWAg@mail.gmail.com> <CAJ-Vmon4Gk6bqoT%2BJf-bRxE0%2BNJ1NjR0wjum-HjoVFDN-2e=8Q@mail.gmail.com> <CAASDrV=pbDpZCGvEjnD8VS0D_HyC8=L3jQ7rfGszG6=PtxaE3Q@mail.gmail.com> <CAASDrVmqijq51OEH7USLutPSgme7YWhXZZX4tGROLHVPoz2VkA@mail.gmail.com> <52E8DDA3.3070301@bitfrost.no> <CAB8uncZVCbFWhJrEosRtRebRip4HjArsZx9FwKE0q9EjYDncmg@mail.gmail.com> <52E9F546.9090005@bitfrost.no> <CAB8unca0ViSrg9ExGX%2BsEfQta9AAXbkKoaGr8RLX1-ksay2tog@mail.gmail.com> <52EB4DBE.20501@bitfrost.no> <52EC07CE.70608@freebsd.org> <52EC2889.9020107@bitfrost.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Hans, Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we can add a notice about that. Table and some structure bt_data, tp_finger from Linux, I only wrote wsp_intr_callback base on usbdump, all other part should be belong to Hans. Cheers, Huang Wen Hui > 在 2014年2月1日，6:49，Hans Petter Selasky <hps@bitfrost.no> 写道： > >> On 01/31/14 21:30, Danilo E. Gondolfo wrote: >>> On 01/31/14 05:16, Hans Petter Selasky wrote: >>>> On 01/31/14 02:46, Huang Wen Hui wrote: >>>> Hi Hans, >>>> >>>> pos_x[] is not non-inialized, it may be previous pos_x, it is still >>>> ok for >>>> getting dx. >>>> "n" var is trying to reduce "untouch" sensor data for post >>>> proccessing. I >>>> attach a new patch >>>> may be more clear, also fixed unexpected movement when button status or >>>> ntouch changing. >>>> >>>> Cheers, >>>> >>>> Huang Wen Hui >>> >>> Hi, >>> >>> http://svnweb.freebsd.org/changeset/base/261315 >>> >>> --HPS >> >> Good work! >> >> I noticed that your driver is based on the Linux driver [1] and some >> pieces of code are copied, are you sure that we won't have any problems >> with license? >> >> These changes can be (should be) merged in the driver atp(4), no? >> >> Danilo. >> >> >> [1] - http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c > > Hi, > > It looks to me like some tables have been copied. We probably should add a notice about that. The rest of the code looks OK to me. > > Huang, any comments? > > --HPS >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?38C22813-14E0-45A2-80CC-ED17525F6B95>