Date: Fri, 04 May 2018 15:55:18 -0700 From: John Baldwin <jhb@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332730 - in head/sys: amd64/amd64 i386/i386 powerpc/powerpc Message-ID: <4861734.o1QKEXXL6r@ralph.baldwin.cx> In-Reply-To: <201804181544.w3IFisf7045389@repo.freebsd.org> References: <201804181544.w3IFisf7045389@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, April 18, 2018 03:44:54 PM Andriy Gapon wrote: > Author: avg > Date: Wed Apr 18 15:44:54 2018 > New Revision: 332730 > URL: https://svnweb.freebsd.org/changeset/base/332730 > > Log: > don't check for kdb reentry in trap_fatal(), it's impossible > > trap() checks for it earlier and calls kdb_reentry(). I just noticed today that there are several other kdb_trap() checks in other architectures that need this fix and the KDB_WHY_TRAP change. Just grep for debugger_on_panic under sys. For example: arm/arm/trap-v4.c: if (debugger_on_panic || kdb_active) arm/arm/trap-v6.c: if (debugger_on_panic || kdb_active) arm64/arm64/trap.c: if (debugger_on_panic || kdb_active) mips/mips/trap.c: if (debugger_on_panic || kdb_active) { -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4861734.o1QKEXXL6r>