Date: Sun, 9 Feb 2025 08:23:50 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Eygene Ryabinkin <rea@freebsd.org> Cc: jsm@freebsd.org, dev-ci@freebsd.org Subject: Re: FreeBSD-main-amd64-gcc13_build - Build #2837 - Still Failing Message-ID: <CAJ-VmonyGxY73Mhcnfsp9av1n0y0nug%2Butzo4DOe6VReg5sw5A@mail.gmail.com> In-Reply-To: <Z6ix343BygnVCJDb@light.codelabs.ru> References: <1655522310.793.1739106980888@jenkins.ci.freebsd.org> <761769956.791.1739106205086@jenkins.ci.freebsd.org> <Z6ix343BygnVCJDb@light.codelabs.ru>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] hi! markj filed a review - https://reviews.freebsd.org/D48903 We're talking about what/how to fix thanks! -a On Sun, 9 Feb 2025 at 05:47, Eygene Ryabinkin <rea@freebsd.org> wrote: > Gentlemen, good day. > > Jenkins passed me the following build errors, since I had receintly > committed to the HEAD (ports-committers.dot). My commit was unrelated > to those build failures, but attached is the patch that fixes > the code of mtw_mcu_radio(): it passes wrond 3-rd argument to the > mtw_mcu_cmd(). Also checked that other invocations of mtw_mcu_cmd() > are fine. > > jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:03:21PM > +0000: > > FreeBSD-main-amd64-gcc13_build - Build #2837 > (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing > > > > Build information: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/ > > Full change log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes > > Full build log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console > > > > Change summaries: > > (Those commits are likely but not certainly responsible) > > > > c945a7832f94c6a46375596f298f6140640722cd by rea: > > Ports committers: add myself > > > > > > > > The end of the build log: > > > > [...truncated 126.38 MiB...] > [...] > > --- all_subdir_usb/mtw --- > > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27: > > In function 'mtw_mcu_cmd', > > inlined from 'mtw_mcu_radio' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10, > > inlined from 'mtw_init_locked' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2, > > inlined from 'mtw_parent' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3: > > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' > forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with > type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds=] > > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), > (len)) > > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of > macro 'memcpy' > > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len); > > | ^~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent': > > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4390:1: note: 'val' declared > here > > 4390 | mtw_init_locked(struct mtw_softc *sc) > > | ^~~~~~~~~~~~~~~ > > > jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:16:17PM > +0000: > > FreeBSD-main-amd64-gcc12_build - Build #4957 > (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing > > > > Build information: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/ > > Full change log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes > > Full build log: > https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console > > > > Change summaries: > > (Those commits are likely but not certainly responsible) > > > > c945a7832f94c6a46375596f298f6140640722cd by rea: > > Ports committers: add myself > > > > > > > > The end of the build log: > > > > [...truncated 125.71 MiB...] > [...] > > --- all_subdir_usb/mtw --- > > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27: > > In function 'mtw_mcu_cmd', > > inlined from 'mtw_mcu_radio' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10, > > inlined from 'mtw_init_locked' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2, > > inlined from 'mtw_parent' at > /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3: > > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' > forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with > type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds] > > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), > (len)) > > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of > macro 'memcpy' > > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len); > > | ^~~~~~ > > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent': > > Please, review and, possibly, commit. > > Thank you. > -- > rea > [-- Attachment #2 --] <div dir="ltr">hi!<div><br></div><div>markj filed a review - <a href="https://reviews.freebsd.org/D48903">https://reviews.freebsd.org/D48903</a></div><div><br></div><div>We're talking about what/how to fix</div><div><br></div><div>thanks!</div><div><br></div><div><br></div><div>-a</div><div><br></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Sun, 9 Feb 2025 at 05:47, Eygene Ryabinkin <<a href="mailto:rea@freebsd.org">rea@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Gentlemen, good day.<br> <br> Jenkins passed me the following build errors, since I had receintly<br> committed to the HEAD (ports-committers.dot). My commit was unrelated<br> to those build failures, but attached is the patch that fixes<br> the code of mtw_mcu_radio(): it passes wrond 3-rd argument to the<br> mtw_mcu_cmd(). Also checked that other invocations of mtw_mcu_cmd()<br> are fine.<br> <br> jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:03:21PM +0000:<br> > FreeBSD-main-amd64-gcc13_build - Build #2837 (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing<br> > <br> > Build information: <a href="https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/" rel="noreferrer" target="_blank">https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/</a><br>; > Full change log: <a href="https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes" rel="noreferrer" target="_blank">https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/changes</a><br>; > Full build log: <a href="https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console" rel="noreferrer" target="_blank">https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc13_build/2837/console</a><br>; > <br> > Change summaries:<br> > (Those commits are likely but not certainly responsible)<br> > <br> > c945a7832f94c6a46375596f298f6140640722cd by rea:<br> > Ports committers: add myself<br> > <br> > <br> > <br> > The end of the build log:<br> > <br> > [...truncated 126.38 MiB...]<br> [...]<br> > --- all_subdir_usb/mtw ---<br> > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27:<br> > In function 'mtw_mcu_cmd',<br> > inlined from 'mtw_mcu_radio' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10,<br> > inlined from 'mtw_init_locked' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2,<br> > inlined from 'mtw_parent' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3:<br> > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds=]<br> > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), (len))<br> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br> > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of macro 'memcpy'<br> > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len);<br> > | ^~~~~~<br> > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent':<br> > /workspace/src/sys/dev/usb/wlan/if_mtw.c:4390:1: note: 'val' declared here<br> > 4390 | mtw_init_locked(struct mtw_softc *sc)<br> > | ^~~~~~~~~~~~~~~<br> <br> <br> jenkins-admin@FreeBSD.org wrote at around Sun, Feb 09, 2025 at 01:16:17PM +0000:<br> > FreeBSD-main-amd64-gcc12_build - Build #4957 (c945a7832f94c6a46375596f298f6140640722cd) - Still Failing<br> > <br> > Build information: <a href="https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/" rel="noreferrer" target="_blank">https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/</a><br>; > Full change log: <a href="https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes" rel="noreferrer" target="_blank">https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/changes</a><br>; > Full build log: <a href="https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console" rel="noreferrer" target="_blank">https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/4957/console</a><br>; > <br> > Change summaries:<br> > (Those commits are likely but not certainly responsible)<br> > <br> > c945a7832f94c6a46375596f298f6140640722cd by rea:<br> > Ports committers: add myself<br> > <br> > <br> > <br> > The end of the build log:<br> > <br> > [...truncated 125.71 MiB...]<br> [...]<br> > --- all_subdir_usb/mtw ---<br> > In file included from /workspace/src/sys/dev/usb/wlan/if_mtw.c:27:<br> > In function 'mtw_mcu_cmd',<br> > inlined from 'mtw_mcu_radio' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4387:10,<br> > inlined from 'mtw_init_locked' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:4513:2,<br> > inlined from 'mtw_parent' at /workspace/src/sys/dev/usb/wlan/if_mtw.c:3490:3:<br> > /workspace/src/sys/sys/systm.h:283:33: warning: '__builtin_memcpy' forming offset [4, 15] is out of the bounds [0, 4] of object 'val' with type 'uint32_t' {aka 'unsigned int'} [-Warray-bounds]<br> > 283 | #define memcpy(to, from, len) __builtin_memcpy((to), (from), (len))<br> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br> > /workspace/src/sys/dev/usb/wlan/if_mtw.c:1407:9: note: in expansion of macro 'memcpy'<br> > 1407 | memcpy(&sc->txd_fw[sc->sc_idx]->fw, buf, len);<br> > | ^~~~~~<br> > /workspace/src/sys/dev/usb/wlan/if_mtw.c: In function 'mtw_parent':<br> <br> Please, review and, possibly, commit.<br> <br> Thank you.<br> -- <br> rea<br> </blockquote></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonyGxY73Mhcnfsp9av1n0y0nug%2Butzo4DOe6VReg5sw5A>