Date: Thu, 09 Feb 2023 10:46:49 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Alexander Leidinger <Alexander@leidinger.net> Cc: dev-commits-src-all@freebsd.org Subject: Re: git: 0dfaefa97547 - main - depend-cleanup.sh: Simplify the logic, and clean bootstrap tools. Message-ID: <86ttzvw4qe.fsf@ltc.des.no> In-Reply-To: <20230209083133.Horde.q3w2RmVjVzPwrvCq2u6yNUU@webmail.leidinger.net> (Alexander Leidinger's message of "Thu, 09 Feb 2023 08:31:33 %2B0100") References: <20230209083133.Horde.q3w2RmVjVzPwrvCq2u6yNUU@webmail.leidinger.net>
index | next in thread | previous in thread | raw e-mail
Alexander Leidinger <Alexander@leidinger.net> writes:
> You change from "no fork+exec if the file doesn't exist" (due to "if"
> and "[" being shell-builtins) to "always fork+exec". On fast machines
> surely not an issue, on slow ones, it may make a difference (I have an
> old amd64 machine at an ISP which takes days to do a buildworld with
> -j2 due to not much memory, only 2 cores, old HDs, and other stuff
> going on in parallel).
Have you measured this? Because the whole point of clean_dep() is that
the file it looks for nearly always exists. It's the grep we're not
sure of. So checking if the file exists is nearly always a waste.
> While the .depend.* namespace is surely controlled by us, would it
> make sense to change the glob to ".{o,pico}" instead of ".*o" instead
> to prevent unexpected surprises in the future?
Our sh does not support the {} syntax. Besides, what would it change?
What else would match .*o but not .{o,pico}?
DES
--
Dag-Erling Smørgrav - des@des.no
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ttzvw4qe.fsf>