Date: Sun, 27 Dec 2015 22:36:43 -0500 From: Patrick Kelsey <pkelsey@freebsd.org> To: Andrey Chernov <ache@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r292823 - in stable/10/sys: conf netinet Message-ID: <0087B045-F70E-4CF5-A1B7-5B421926BB5A@freebsd.org> In-Reply-To: <5680A991.5040301@freebsd.org> References: <201512280243.tBS2hD7X008202@repo.freebsd.org> <5680A574.9050002@freebsd.org> <5680A991.5040301@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 27, 2015, at 10:16 PM, Andrey Chernov <ache@freebsd.org> wrote: >=20 >> On 28.12.2015 5:59, Andrey Chernov wrote: >>> On 28.12.2015 5:43, Patrick Kelsey wrote: >>> Author: pkelsey >>> Date: Mon Dec 28 02:43:12 2015 >>> New Revision: 292823 >>> URL: https://svnweb.freebsd.org/changeset/base/292823 >>>=20 >>> Log: >>> MFC r292706: >>>=20 >>> Implementation of server-side TCP Fast Open (TFO) [RFC7413]. >>>=20 >>> TFO is disabled by default in the kernel build. See the top comment >>> in sys/netinet/tcp_fastopen.c for implementation particulars. >>=20 >> Why it is disabled by default? Do we need some rc.conf knobs to not deal >> directly with it, like tcp_extensions? OMG, why it is kernel config and >> not boot-time sysctl? >=20 > BTW, TCP_RFC7413_MAX_KEYS currently unused and I have no clues what it > supposed to be. I can't find it in the phabric patch at all. >=20 Look at line 127 in tcp_fastopen.c. Also, read the top comment in tcp_fasto= pen.c. Phabricator is buggy and unreliable, and using it as a primary reference to t= he code will let you down as it has let me down, repeatedly. For example, i= t will not show you the contents of entirely new files unless you manually u= pload them - I believe this what is currently affecting your viewpoint. -Patrick=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0087B045-F70E-4CF5-A1B7-5B421926BB5A>