Date: Fri, 23 Oct 2009 15:14:54 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/kern kern_exec.c kern_ktrace.c subr_bus.c subr_taskqueue.c src/sys/sys interrupt.h Message-ID: <200910231515.n9NFFHas020743@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2009-10-23 15:14:54 UTC
FreeBSD src repository
Modified files:
sys/kern kern_exec.c kern_ktrace.c subr_bus.c
subr_taskqueue.c
sys/sys interrupt.h
Log:
SVN rev 198411 on 2009-10-23 15:14:54Z by jhb
- Fix several off-by-one errors when using MAXCOMLEN. The p_comm[] and
td_name[] arrays are actually MAXCOMLEN + 1 in size and a few places that
created shadow copies of these arrays were just using MAXCOMLEN.
- Prefer using sizeof() of an array type to explicit constants for the
array length in a few places.
- Ensure that all of p_comm[] and td_name[] is always zero'd during
execve() to guard against any possible information leaks. Previously
trailing garbage in p_comm[] could be leaked to userland in ktrace
record headers via td_name[].
Reviewed by: bde
Revision Changes Path
1.340 +7 -13 src/sys/kern/kern_exec.c
1.131 +6 -1 src/sys/kern/kern_ktrace.c
1.234 +1 -1 src/sys/kern/subr_bus.c
1.52 +2 -2 src/sys/kern/subr_taskqueue.c
1.48 +3 -3 src/sys/sys/interrupt.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910231515.n9NFFHas020743>