Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Apr 2017 16:51:09 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Ngie Cooper <yaneurabeya@gmail.com>
Cc:        Benjamin Kaduk <bjkfbsd@gmail.com>, John Baldwin <jhb@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r317409 - head/contrib/tcpdump
Message-ID:  <ac6ceb4b-e1f9-5fe7-770b-6f2f165b147f@FreeBSD.org>
In-Reply-To: <CAGHfRMATSJm2wGdzxRRNc7kSyyg3H8K_xeHo04XXSu5=rrv3pQ@mail.gmail.com>
References:  <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com> <edda9d8c-118b-4b91-1b06-fdbcda786b9b@FreeBSD.org> <CAGHfRMATSJm2wGdzxRRNc7kSyyg3H8K_xeHo04XXSu5=rrv3pQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb
Content-Type: multipart/mixed; boundary="4q40ISJpAo5TKdibfNNkojVDsSetcAbhI";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Ngie Cooper <yaneurabeya@gmail.com>
Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, John Baldwin <jhb@freebsd.org>,
 "Rodney W. Grimes" <rgrimes@freebsd.org>, Gleb Smirnoff
 <glebius@freebsd.org>, "svn-src-head@freebsd.org"
 <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org"
 <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
Message-ID: <ac6ceb4b-e1f9-5fe7-770b-6f2f165b147f@FreeBSD.org>
Subject: Re: svn commit: r317409 - head/contrib/tcpdump
References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net>
 <9709200.gDHZIeQ1vL@ralph.baldwin.cx>
 <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com>
 <edda9d8c-118b-4b91-1b06-fdbcda786b9b@FreeBSD.org>
 <CAGHfRMATSJm2wGdzxRRNc7kSyyg3H8K_xeHo04XXSu5=rrv3pQ@mail.gmail.com>
In-Reply-To: <CAGHfRMATSJm2wGdzxRRNc7kSyyg3H8K_xeHo04XXSu5=rrv3pQ@mail.gmail.com>

--4q40ISJpAo5TKdibfNNkojVDsSetcAbhI
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 4/25/2017 3:12 PM, Ngie Cooper wrote:
> On Tue, Apr 25, 2017 at 2:26 PM, Bryan Drewery <bdrewery@freebsd.org> w=
rote:
>=20
> ...
>=20
>> It is definitely more useful to note which repository and what VCS
>> system the revision/hash/version refers to.  But there's nothing
>> inherently wrong about using a git hash.  Github !=3D git. It is merel=
y an
>> interface to git and is not required to use any of the git repositorie=
s
>> on it given another mirror or local checkout.  If a project uses git a=
s
>> their official VCS then a git hash is the proper reference.
>=20
>     The only issues with using git hashes stems from forced pushes and
> the fact that only hashes can be garbage collected, but if we're using
> an upstream that does that, they are using git wrong (it should only
> be done for non-development mainlines). Then again, at least the
> history will have been somewhat correct, as cvs/svn history can be
> rewritten :/...
> Thanks,
> -Ngie
>=20

"Force push". This exact same thing can happen with SVN and CVS by a
repository admin. Respectable projects that are using git officially
won't rebase their main branches unless under severe circumstance. Same
for SVN/CVS. SVN->GIT mirrors or CVS->GIT mirrors may be prone to that
naturally though, but we should not be cherry-picking from that since it
is not the source of truth for the project.

--=20
Regards,
Bryan Drewery


--4q40ISJpAo5TKdibfNNkojVDsSetcAbhI--

--1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJY/+DtAAoJEDXXcbtuRpfPNsYIALSGtV8O8zXZyFU1X0uV7A/S
q3WmBafTHo6ddamTWbOJwSBncyivznOofnS6BKXSER59hsjhxGF5JYUp1hz7xBr1
nvGbqqZVxyBzLlBfSWVNWzZoeg33EpFakamaQEOKxeLb8IEFd4wJ2QCfQfCMlVkH
mmbLrKxgYIVp9bhsYvx8RLIxPg0GMdG+O5h//nHGfmfp7p2TU3bQZp7J5VaAo909
vuZcBYj3JLnZ9dp4CagouqFcqIq8zhJDyToTc8AVdrV8cAWgm4+50SZstZOoE5Y8
LTabiRYEjQ7AslgA2m0r5OnVLPbf9GIHBwiT/QTK7s3MzH1wvXjJxOfAQpDvoqc=
=+jZh
-----END PGP SIGNATURE-----

--1av2RsgcVk5Jaqpwq0lLXKGuk4W6im5Hb--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac6ceb4b-e1f9-5fe7-770b-6f2f165b147f>