Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 May 2005 10:47:01 -0400
From:      Tom Rhodes <trhodes@FreeBSD.org>
To:        "Christian S.J. Peron" <csjp@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   Re: PERFORCE change 77201 for review
Message-ID:  <20050520104701.7658a5d5@mobile.pittgoth.com>
In-Reply-To: <200505200017.j4K0HmZP080639@repoman.freebsd.org>
References:  <200505200017.j4K0HmZP080639@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 May 2005 00:17:48 GMT
"Christian S.J. Peron" <csjp@freebsd.org> wrote:

> http://perforce.freebsd.org/chv.cgi?CH=77201
> 
> Change 77201 by csjp@csjp_xor on 2005/05/20 00:17:30
> 
> 	
> 	-replace a size_t for int in the checksum calculation routines
> 	-declare temp variable to stuff the size of the extended attribute in.
> 	 We have to do this because for some reason the data type representing
> 	 extended attribute size between vn_extattr_get and VOP_GETEXTATTR conflict.
> 	 This makes the mac_chkexec build happy on AMD64

Requested by:	trhodes

Thanks!!!

[SNIP]

>  		return (error);
> +	/* XXX why are'nt extended attribute size specification types between
> +	 * VOP_GETEXTATTR and vn_extattr_get the same?
> +	 */
> +	alen = ealen;
>  	depends = malloc(alen + 1, M_CHKEXEC, M_WAITOK | M_ZERO);
>  	error = vn_extattr_get(vp, IO_NODELOCKED, MAC_CHKEXEC_ATTRN,
>  	    MAC_CHKEXEC_DEP, &alen, depends, curthread);
> 

Good question.

-- 
Tom Rhodes



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050520104701.7658a5d5>