Date: Sun, 3 Aug 2008 11:38:49 +0400 (MSD) From: Chagin Dmitry <chagin.dmitry@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: freebsd-emulation@freebsd.org, Chagin Dmitry <chagin.dmitry@gmail.com> Subject: Re: [PATCH]Re: kern/122318 (CMake core dumping, chroot exiting) Message-ID: <alpine.BSF.1.10.0808031134260.84147@ora.chd.net> In-Reply-To: <20080803073044.GA4624@freebsd.org> References: <alpine.BSF.1.10.0807231236140.12600@thor.farley.org> <alpine.BSF.1.10.0808030024140.81282@ora.chd.net> <20080802222109.GA78151@freebsd.org> <alpine.BSF.1.10.0808030252230.82585@ora.chd.net> <20080803073044.GA4624@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 3 Aug 2008, Roman Divacky wrote: > On Sun, Aug 03, 2008 at 02:54:53AM +0400, Chagin Dmitry wrote: >> On Sun, 3 Aug 2008, Roman Divacky wrote: >> >>> On Sun, Aug 03, 2008 at 12:53:58AM +0400, Chagin Dmitry wrote: >>>> On Wed, 23 Jul 2008, Sean C. Farley wrote: >>>> >>>>> I am seeing if anyone has any insight on this PR (kern/122318[1]). It >>>>> would be nice to once again build using cmake within a Linux chroot. :) >>>>> >>>>> Basically, the bug is that not only that cmake is dumping core; it is >>>>> also forcing the user out of the chroot environment. Here is the >>>>> command used to start the chroot: >>>>> /compat/linux/usr/sbin/chroot <chroot path> su - <build user> >>>>> >>>>> Thank you. >>>>> >>>>> Sean >>>>> 1. http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/122318 >>>>> >>>> >>>> here patches for -current and releng_7: >>>> http://78.107.232.239/rt_signals-current.patch >>>> http://78.107.232.239/rt_signals-releng_7.patch >>>> >>>> what patch do: >>>> - rt sigtramp code works (this solves PR) >>>> - align stack pointers >>>> - remove kern_sigaltstack() at the end of rt_sigreturn(), it's a bogus. >>>> Here there is some information on it: >>>> http://www.ussg.iu.edu/hypermail/linux/kernel/0405.2/1283.html >>> >>> I quickly skimmed over it and it looks correct, but please avoid >>> making gratuitous changes like moving stuff before comment after >>> the comment etc. >>> >> >> I have simply transferred a line on place where it should be :) > > no problem with the change itself but including it in the patch > makes the patch bigger and harder to review ok > >>> I will do a little more thorough review but so far it looks good >>> >> >> and please, test it on i386. > > test with the cmake? > no, with special test http://78.107.232.239/tst_rtsig.c cmake differs only that that uses select() and I sigsuspend() for sleep. -- Have fun! chd
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.1.10.0808031134260.84147>